[Scummvm-cvs-logs] SF.net SVN: scummvm:[40616] scummvm/trunk/engines/cruise

[dreammaster at users.sourceforge.net]

Revision: 40616
          http://scummvm.svn.sourceforge.net/scummvm/?rev=40616&view=rev
Author:   dreammaster
Date:     2009-05-16 04:03:37 +0000 (Sat, 16 May 2009)

Log Message:
-----------
Replaced value with proper constant, and named a previously un-named structure field

Modified Paths:
--------------
    scummvm/trunk/engines/cruise/backgroundIncrust.cpp
    scummvm/trunk/engines/cruise/backgroundIncrust.h
    scummvm/trunk/engines/cruise/saveload.cpp

Modified: scummvm/trunk/engines/cruise/backgroundIncrust.cpp
===================================================================
--- scummvm/trunk/engines/cruise/backgroundIncrust.cpp	2009-05-16 00:33:49 UTC (rev 40615)
+++ scummvm/trunk/engines/cruise/backgroundIncrust.cpp	2009-05-16 04:03:37 UTC (rev 40616)
@@ -37,7 +37,7 @@
 
 // blit background to another one
 void addBackgroundIncrustSub1(int fileIdx, int X, int Y, char *ptr2, int16 scale, char *destBuffer, char *dataPtr) {
-	assert(*dataPtr != 0);
+	assert((dataPtr != NULL) && (*dataPtr != 0));
 
 	buildPolyModel(X, Y, scale, ptr2, destBuffer, dataPtr);
 }
@@ -142,7 +142,7 @@
 	newElement->X = params.X;
 	newElement->Y = params.Y;
 	newElement->scale = params.scale;
-	newElement->field_E = params.fileIdx;
+	newElement->frame = params.fileIdx;
 	newElement->spriteId = filesDatabase[params.fileIdx].subData.index;
 	newElement->ptr = NULL;
 	strcpy(newElement->name, filesDatabase[params.fileIdx].subData.name);
@@ -195,7 +195,7 @@
 		backgroundIncrustStruct* pl2 = pl->next;
 
 		bool bLoad = false;
-		int frame = pl->field_E;
+		int frame = pl->frame;
 		//int screen = pl->backgroundIdx;
 
 		if ((filesDatabase[frame].subData.ptr == NULL) || (strcmp(pl->name, filesDatabase[frame].subData.name))) {
@@ -207,13 +207,15 @@
 			}
 		}
 
-		if (frame >= -1) {
-			if (filesDatabase[frame].subData.resourceType == 4) {	// sprite
+		if (frame >= 0) {
+			if (filesDatabase[frame].subData.resourceType == OBJ_TYPE_SPRITE) {
+				// Sprite
 				int width = filesDatabase[frame].width;
 				int height = filesDatabase[frame].height;
 
 				drawSprite(width, height, NULL, filesDatabase[frame].subData.ptr, pl->Y, pl->X, backgroundScreens[pl->backgroundIdx], filesDatabase[frame].subData.ptrMask);
-			} else {			// poly
+			} else {
+				// Poly
 				addBackgroundIncrustSub1(frame, pl->X, pl->Y, NULL, pl->scale, (char*)backgroundScreens[pl->backgroundIdx], (char *)filesDatabase[frame].subData.ptr);
 			}
 		}

Modified: scummvm/trunk/engines/cruise/backgroundIncrust.h
===================================================================
--- scummvm/trunk/engines/cruise/backgroundIncrust.h	2009-05-16 00:33:49 UTC (rev 40615)
+++ scummvm/trunk/engines/cruise/backgroundIncrust.h	2009-05-16 04:03:37 UTC (rev 40616)
@@ -37,7 +37,7 @@
 	uint16 overlayIdx;
 	int16 X;
 	int16 Y;
-	uint16 field_E;
+	uint16 frame;
 	uint16 scale;
 	uint16 backgroundIdx;
 	uint16 scriptNumber;

Modified: scummvm/trunk/engines/cruise/saveload.cpp
===================================================================
--- scummvm/trunk/engines/cruise/saveload.cpp	2009-05-16 00:33:49 UTC (rev 40615)
+++ scummvm/trunk/engines/cruise/saveload.cpp	2009-05-16 04:03:37 UTC (rev 40616)
@@ -453,7 +453,7 @@
 		s.syncAsSint16LE(t->overlayIdx);
 		s.syncAsSint16LE(t->X);
 		s.syncAsSint16LE(t->Y);
-		s.syncAsSint16LE(t->field_E);
+		s.syncAsSint16LE(t->frame);
 		s.syncAsSint16LE(t->scale);
 		s.syncAsSint16LE(t->backgroundIdx);
 		s.syncAsSint16LE(t->scriptNumber);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.