[Scummvm-cvs-logs] SF.net SVN: scummvm:[40943] scummvm/trunk/engines/sci

[thebluegr at users.sourceforge.net]

Revision: 40943
          http://scummvm.svn.sourceforge.net/scummvm/?rev=40943&view=rev
Author:   thebluegr
Date:     2009-05-27 16:45:42 +0000 (Wed, 27 May 2009)

Log Message:
-----------
- SQ5 floppy starts now
- Added a new console command, "room", which shows the current room

Modified Paths:
--------------
    scummvm/trunk/engines/sci/console.cpp
    scummvm/trunk/engines/sci/console.h
    scummvm/trunk/engines/sci/engine/ksound.cpp
    scummvm/trunk/engines/sci/gfx/gfx_driver.cpp

Modified: scummvm/trunk/engines/sci/console.cpp
===================================================================
--- scummvm/trunk/engines/sci/console.cpp	2009-05-27 15:12:53 UTC (rev 40942)
+++ scummvm/trunk/engines/sci/console.cpp	2009-05-27 16:45:42 UTC (rev 40943)
@@ -88,6 +88,7 @@
 	DCmd_Register("man",				WRAP_METHOD(Console, cmdMan));
 	DCmd_Register("hexdump",			WRAP_METHOD(Console, cmdHexDump));
 	DCmd_Register("dissect_script",		WRAP_METHOD(Console, cmdDissectScript));
+	DCmd_Register("room",				WRAP_METHOD(Console, cmdRoomNumber));
 }
 
 Console::~Console() {
@@ -323,4 +324,10 @@
 	return true;
 }
 
+bool Console::cmdRoomNumber(int argc, const char **argv) {
+	DebugPrintf("Current room number is %d\n", g_EngineState->currentRoomNumber());
+
+	return true;
+}
+
 } // End of namespace Sci

Modified: scummvm/trunk/engines/sci/console.h
===================================================================
--- scummvm/trunk/engines/sci/console.h	2009-05-27 15:12:53 UTC (rev 40942)
+++ scummvm/trunk/engines/sci/console.h	2009-05-27 16:45:42 UTC (rev 40943)
@@ -53,6 +53,7 @@
 	bool cmdMan(int argc, const char **argv);
 	bool cmdHexDump(int argc, const char **argv);
 	bool cmdDissectScript(int argc, const char **argv);
+	bool cmdRoomNumber(int argc, const char **argv);
 
 private:
 	SciEngine *_vm;

Modified: scummvm/trunk/engines/sci/engine/ksound.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/ksound.cpp	2009-05-27 15:12:53 UTC (rev 40942)
+++ scummvm/trunk/engines/sci/engine/ksound.cpp	2009-05-27 16:45:42 UTC (rev 40943)
@@ -1076,6 +1076,7 @@
 				PUT_SEL32V(argv[1], syncCue, -1);
 			}
 		} else if (argc == 7) {		// SQ4CD or newer
+			// TODO
 			warning("kDoSync: Start called with new semantics - 6 parameters: %d %d %d %d %d %d", UKPV(1), UKPV(2), UKPV(3), UKPV(4), UKPV(5), UKPV(6));
 		} else {					// Hopefully, this should never happen
 			warning("kDoSync: Start called with an unknown number of parameters (%d)", argc);

Modified: scummvm/trunk/engines/sci/gfx/gfx_driver.cpp
===================================================================
--- scummvm/trunk/engines/sci/gfx/gfx_driver.cpp	2009-05-27 15:12:53 UTC (rev 40942)
+++ scummvm/trunk/engines/sci/gfx/gfx_driver.cpp	2009-05-27 16:45:42 UTC (rev 40943)
@@ -264,7 +264,8 @@
 		for (int xc = 0; xc < pointer->index_width; xc++) {
 			uint8 color = *src;
 			// FIXME: The palette size check is a workaround for cursors using non-palette colour GFX_CURSOR_TRANSPARENT
-			if (color < pointer->palette->size())
+			// Note that some cursors don't have a palette in SQ5
+			if (pointer->palette && color < pointer->palette->size())
 				color = pointer->palette->getColor(color).parent_index;
 			for (int scalectr = 0; scalectr < drv->mode->xfact; scalectr++) {
 				*pos++ = color;
@@ -287,9 +288,14 @@
 		S->pointer_data = create_cursor(drv, pointer, 1);
 
 		// FIXME: The palette size check is a workaround for cursors using non-palette colour GFX_CURSOR_TRANSPARENT
+		// Note that some cursors don't have a palette in SQ5
 		uint8 color_key = GFX_CURSOR_TRANSPARENT;
-		if ((pointer->color_key != GFX_PIXMAP_COLOR_KEY_NONE) && ((unsigned int)pointer->color_key < pointer->palette->size()))
+		if ((pointer->color_key != GFX_PIXMAP_COLOR_KEY_NONE) && (pointer->palette && (unsigned int)pointer->color_key < pointer->palette->size()))
 			color_key = pointer->palette->getColor(pointer->color_key).parent_index;
+		// Some cursors in SQ5 don't have a palette. The cursor palette seems to use 64 colors, so setting the color key to 63 works
+		// TODO: Is this correct?
+		if (!pointer->palette)
+			color_key = 63;
 
 		g_system->setMouseCursor(S->pointer_data, pointer->width, pointer->height, hotspot->x, hotspot->y, color_key);
 		g_system->showMouse(true);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.