[Scummvm-cvs-logs] SF.net SVN: scummvm:[45768] scummvm/trunk/engines/draci

[spalek at users.sourceforge.net]

Revision: 45768
          http://scummvm.svn.sourceforge.net/scummvm/?rev=45768&view=rev
Author:   spalek
Date:     2009-11-08 22:48:27 +0000 (Sun, 08 Nov 2009)

Log Message:
-----------
Updated the list of TODOs

Modified Paths:
--------------
    scummvm/trunk/engines/draci/music.cpp
    scummvm/trunk/engines/draci/screen.cpp
    scummvm/trunk/engines/draci/script.cpp
    scummvm/trunk/engines/draci/sprite.cpp
    scummvm/trunk/engines/draci/walking.cpp

Modified: scummvm/trunk/engines/draci/music.cpp
===================================================================
--- scummvm/trunk/engines/draci/music.cpp	2009-11-08 22:37:03 UTC (rev 45767)
+++ scummvm/trunk/engines/draci/music.cpp	2009-11-08 22:48:27 UTC (rev 45768)
@@ -125,6 +125,8 @@
 
 	if (!_channel[channel]) {
 		_channel[channel] = (channel == 9) ? _driver->getPercussionChannel() : _driver->allocateChannel();
+		// If a new channel is allocated during the playback, make sure
+		// its volume is correctly initialized.
 		setChannelVolume(channel);
 	}
 
@@ -232,12 +234,6 @@
 	int volume = ConfMan.getInt("music_volume");
 	debugC(2, kDraciSoundDebugLevel, "Syncing music volume to %d", volume);
 	setVolume(volume);
-
-	// TODO: doesn't work in the beginning when no music is playing yet.
-	// It goes through all active channels (= none) and stops.  Only after
-	// actual instruments have played in the channels, this has an effect.
-	// As a consequence, music is very loud in the beginning until Ctrl-F5
-	// is pressed for the first time.
 }
 
 } // End of namespace Draci

Modified: scummvm/trunk/engines/draci/screen.cpp
===================================================================
--- scummvm/trunk/engines/draci/screen.cpp	2009-11-08 22:37:03 UTC (rev 45767)
+++ scummvm/trunk/engines/draci/screen.cpp	2009-11-08 22:48:27 UTC (rev 45768)
@@ -88,7 +88,6 @@
 		_palette[i * 4 + 3] = 0;
 	}
 
-	// TODO: Investigate why this is needed
 	// Shift the palette two bits to the left to make it brighter
 	for (int i = start * 4; i < (start + num) * 4; ++i) {
 		_palette[i] <<= 2;

Modified: scummvm/trunk/engines/draci/script.cpp
===================================================================
--- scummvm/trunk/engines/draci/script.cpp	2009-11-08 22:37:03 UTC (rev 45767)
+++ scummvm/trunk/engines/draci/script.cpp	2009-11-08 22:48:27 UTC (rev 45768)
@@ -572,6 +572,7 @@
 		}
 
 		if (_vm->_mouse->getCursorType() == kNormalCursor) {
+			// TODO: is this correct?
 			if (_vm->_game->getLoopStatus() == kStatusInventory) {
 				_vm->_mouse->cursorOff();
 			}

Modified: scummvm/trunk/engines/draci/sprite.cpp
===================================================================
--- scummvm/trunk/engines/draci/sprite.cpp	2009-11-08 22:37:03 UTC (rev 45767)
+++ scummvm/trunk/engines/draci/sprite.cpp	2009-11-08 22:48:27 UTC (rev 45768)
@@ -307,8 +307,8 @@
 	_font->drawString(surface, _text, _x + relX, _y + relY, _colour, _spacing, true);
 }
 
-// TODO: Handle scaled parameter properly by implementing Text scaling
 Common::Rect Text::getRect(const Displacement &displacement) const {
+	// Texts are never scaled
 	return Common::Rect(_x + displacement.relX, _y + displacement.relY, _x + displacement.relX + _width, _y + displacement.relY + _height);
 }
 

Modified: scummvm/trunk/engines/draci/walking.cpp
===================================================================
--- scummvm/trunk/engines/draci/walking.cpp	2009-11-08 22:37:03 UTC (rev 45767)
+++ scummvm/trunk/engines/draci/walking.cpp	2009-11-08 22:48:27 UTC (rev 45768)
@@ -645,7 +645,7 @@
 	Movement nextAnim = directionForNextPhase();
 	_lastAnimPhase = _vm->_game->playHeroAnimation(nextAnim);
 
-	// TODO: do we need to clear this callback for the animation?
+	// TODO: do we need to clear the callback for the turning animation?
 
 	debugC(2, kDraciWalkingDebugLevel, "Turned for edge %d, starting animation %d with phase %d", _segment, nextAnim, _lastAnimPhase);
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.