[Scummvm-cvs-logs] SF.net SVN: scummvm:[45816] scummvm/trunk/common/scummsys.h

[lordhoto at users.sourceforge.net]

Revision: 45816
          http://scummvm.svn.sourceforge.net/scummvm/?rev=45816&view=rev
Author:   lordhoto
Date:     2009-11-10 21:14:48 +0000 (Tue, 10 Nov 2009)

Log Message:
-----------
Add some FIXME comments about defining types from stdint.h on our own.

Modified Paths:
--------------
    scummvm/trunk/common/scummsys.h

Modified: scummvm/trunk/common/scummsys.h
===================================================================
--- scummvm/trunk/common/scummsys.h	2009-11-10 21:14:27 UTC (rev 45815)
+++ scummvm/trunk/common/scummsys.h	2009-11-10 21:14:48 UTC (rev 45816)
@@ -198,6 +198,9 @@
 	#define SMALL_SCREEN_DEVICE
 	#endif
 
+	// FIXME: It is not the nicest idea to define these types
+	// on our own, since they should be defined in "stdint.h"
+	// for compilers with a C99 library.
 	typedef signed char int8_t;
 	typedef signed short int16_t;
 	typedef unsigned char uint8_t;
@@ -215,6 +218,19 @@
 	#define NORETURN __declspec(noreturn)
 	#define PLUGIN_EXPORT __declspec(dllexport)
 
+	// FIXME: It is not the nicest idea to define these types
+	// on our own, since they should be defined in "stdint.h"
+	// for compilers with a C99 library. Since MSVC does not
+	// supply any C99 headers, we must define these types
+	// on owr own, sadly SDL seems to do the same, but they
+	// define "uint32_t" as "unsigned __int32" and "int32_t"
+	// as "signed __int32", which leads to compilation errors
+	// when this file is included before SDL.h.
+	// We might either switch to the same definitions SDL.h
+	// uses or clean this up in a different way, it seems
+	// the only code relying on these types is the MPEG2
+	// code, so maybe we can move this a bit more locally
+	// to the MPEG2 code.
 	typedef signed char int8_t;
 	typedef signed short int16_t;
 	typedef unsigned char uint8_t;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.