[Scummvm-cvs-logs] SF.net SVN: scummvm:[45874] scummvm/trunk/engines/draci

[spalek at users.sourceforge.net]

Revision: 45874
          http://scummvm.svn.sourceforge.net/scummvm/?rev=45874&view=rev
Author:   spalek
Date:     2009-11-12 22:57:01 +0000 (Thu, 12 Nov 2009)

Log Message:
-----------
Removed 2 old TODOs

Modified Paths:
--------------
    scummvm/trunk/engines/draci/draci.cpp
    scummvm/trunk/engines/draci/sound.cpp

Modified: scummvm/trunk/engines/draci/draci.cpp
===================================================================
--- scummvm/trunk/engines/draci/draci.cpp	2009-11-12 22:52:00 UTC (rev 45873)
+++ scummvm/trunk/engines/draci/draci.cpp	2009-11-12 22:57:01 UTC (rev 45874)
@@ -296,8 +296,10 @@
 DraciEngine::~DraciEngine() {
 	// Dispose your resources here
 
- 	// TODO: Investigate possibility of using sharedPtr or similar
-
+	// If the common library supported STL's scoped_ptr<>, then wrapping
+	// all the following pointers and many more would be appropriate.  So
+	// far, there is only SharedPtr, which I feel being an overkill for
+	// easy deallocation.
 	delete _smallFont;
 	delete _bigFont;
 

Modified: scummvm/trunk/engines/draci/sound.cpp
===================================================================
--- scummvm/trunk/engines/draci/sound.cpp	2009-11-12 22:52:00 UTC (rev 45873)
+++ scummvm/trunk/engines/draci/sound.cpp	2009-11-12 22:57:01 UTC (rev 45874)
@@ -264,7 +264,6 @@
 }
 
 void Sound::setVolume() {
-	// TODO: how to retrieve "Mute All" ?
         if (_mixer->isReady()) {
                 _muteSound = ConfMan.getBool("sfx_mute");
                 _muteVoice = ConfMan.getBool("speech_mute");


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.