[Scummvm-cvs-logs] SF.net SVN: scummvm:[46046] scummvm/trunk/common/archive.cpp

[lordhoto at users.sourceforge.net]

Revision: 46046
          http://scummvm.svn.sourceforge.net/scummvm/?rev=46046&view=rev
Author:   lordhoto
Date:     2009-11-21 20:19:15 +0000 (Sat, 21 Nov 2009)

Log Message:
-----------
Change Archive::listMatchingMembers to match the pattern case-insensitively.

Modified Paths:
--------------
    scummvm/trunk/common/archive.cpp

Modified: scummvm/trunk/common/archive.cpp
===================================================================
--- scummvm/trunk/common/archive.cpp	2009-11-21 20:18:51 UTC (rev 46045)
+++ scummvm/trunk/common/archive.cpp	2009-11-21 20:19:15 UTC (rev 46046)
@@ -50,13 +50,11 @@
 
 	int matches = 0;
 
-	// need to match lowercase key
-	String lowercasePattern = pattern;
-	lowercasePattern.toLowercase();
-
 	ArchiveMemberList::iterator it = allNames.begin();
 	for ( ; it != allNames.end(); ++it) {
-		if ((*it)->getName().matchString(lowercasePattern, false, true)) {
+		// TODO: We match case-insenstivie for now, our API does not define whether that's ok or not though...
+		// For our use case case-insensitive is probably what we want to have though.
+		if ((*it)->getName().matchString(lowercasePattern, true, true)) {
 			list.push_back(*it);
 			matches++;
 		}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.