[Scummvm-cvs-logs] SF.net SVN: scummvm:[44513] scummvm/trunk/engines/sci

wjpalenstijn at users.sourceforge.net wjpalenstijn at users.sourceforge.net
Thu Oct 1 13:06:38 CEST 2009


Revision: 44513
          http://scummvm.svn.sourceforge.net/scummvm/?rev=44513&view=rev
Author:   wjpalenstijn
Date:     2009-10-01 11:06:38 +0000 (Thu, 01 Oct 2009)

Log Message:
-----------
SCI: Add some fixmes noted by salty-horse.

Modified Paths:
--------------
    scummvm/trunk/engines/sci/console.cpp
    scummvm/trunk/engines/sci/sfx/softseq/amiga.cpp

Modified: scummvm/trunk/engines/sci/console.cpp
===================================================================
--- scummvm/trunk/engines/sci/console.cpp	2009-10-01 11:02:23 UTC (rev 44512)
+++ scummvm/trunk/engines/sci/console.cpp	2009-10-01 11:06:38 UTC (rev 44513)
@@ -2719,7 +2719,9 @@
 	return true;
 }
 
-int parse_reg_t(EngineState *s, const char *str, reg_t *dest) { // Returns 0 on success
+// Returns 0 on success
+int parse_reg_t(EngineState *s, const char *str, reg_t *dest) {
+	// FIXME: Stop this function from changing str.
 	int rel_offsetting = 0;
 	const char *offsetting = NULL;
 	// Non-NULL: Parse end of string for relative offsets

Modified: scummvm/trunk/engines/sci/sfx/softseq/amiga.cpp
===================================================================
--- scummvm/trunk/engines/sci/sfx/softseq/amiga.cpp	2009-10-01 11:02:23 UTC (rev 44512)
+++ scummvm/trunk/engines/sci/sfx/softseq/amiga.cpp	2009-10-01 11:06:38 UTC (rev 44513)
@@ -565,6 +565,7 @@
 void ami_poll(sfx_softseq_t *self, byte *dest, int len) {
 	int i, j;
 	int16 *buf = (int16 *) dest;
+	// FIXME: memleak
 	int16 *buffers = (int16*)malloc(len * 2 * CHANNELS_NR);
 
 	memset(buffers, 0, len * 2 * CHANNELS_NR);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list