[Scummvm-cvs-logs] SF.net SVN: scummvm:[44751] scummvm/trunk/engines/sci/gui/gui_view.cpp

[m_kiewitz at users.sourceforge.net]

Revision: 44751
          http://scummvm.svn.sourceforge.net/scummvm/?rev=44751&view=rev
Author:   m_kiewitz
Date:     2009-10-07 20:04:48 +0000 (Wed, 07 Oct 2009)

Log Message:
-----------
SCI/newgui: SciGuiView - paletteoffset in EGA games documented and finally not used

Modified Paths:
--------------
    scummvm/trunk/engines/sci/gui/gui_view.cpp

Modified: scummvm/trunk/engines/sci/gui/gui_view.cpp
===================================================================
--- scummvm/trunk/engines/sci/gui/gui_view.cpp	2009-10-07 19:57:32 UTC (rev 44750)
+++ scummvm/trunk/engines/sci/gui/gui_view.cpp	2009-10-07 20:04:48 UTC (rev 44751)
@@ -89,10 +89,9 @@
 		palOffset = READ_LE_UINT16(_resourceData + 6);
 
 		if (palOffset && palOffset != 0x100) {
-			if (IsEGA) { // simple mapping for 16 colors
-				// FIXME: this messes up the colors in Codename: Iceman
-				//_EGAMapping = _resourceData + palOffset;
-			} else {
+			// Some games also have an offset set. It seems that it points to a 16-byte mapping table
+			//  cels also work by not using it, so we dont.
+			if (!IsEGA) {
 				_palette->createFromData(&_resourceData[palOffset], &_viewPalette);
 				_embeddedPal = true;
 			}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.