[Scummvm-cvs-logs] SF.net SVN: scummvm:[44112] scummvm/trunk/engines/cine/pal.cpp

lordhoto at users.sourceforge.net lordhoto at users.sourceforge.net
Wed Sep 16 00:16:57 CEST 2009


Revision: 44112
          http://scummvm.svn.sourceforge.net/scummvm/?rev=44112&view=rev
Author:   lordhoto
Date:     2009-09-15 22:16:55 +0000 (Tue, 15 Sep 2009)

Log Message:
-----------
Add link to gcc bug report, in the comment for the gcc aimed workaround for AMD64.

Modified Paths:
--------------
    scummvm/trunk/engines/cine/pal.cpp

Modified: scummvm/trunk/engines/cine/pal.cpp
===================================================================
--- scummvm/trunk/engines/cine/pal.cpp	2009-09-15 20:58:30 UTC (rev 44111)
+++ scummvm/trunk/engines/cine/pal.cpp	2009-09-15 22:16:55 UTC (rev 44112)
@@ -223,8 +223,11 @@
 		// even though the struct is only 3 bytes, resulting in an invalid read, when accessing indices
 		// 14 and 15 of 16 color palettes.
 		//
-		// To work around this issue, we added an temporary variable, which will have padding so
+		// To work around this issue, we added an temporary variable, which will have padding, so
 		// the 8 byte read (which is done when passing src) is assured to be in a valid memory area.
+		//
+		// For more information about this gcc specific problem, you can read up on the following bug
+		// report: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36043
 		const Color src = _colors[i];
 		output._colors[i] = saturatedAddColor(src, r, g, b);
 	}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list