[Scummvm-cvs-logs] SF.net SVN: scummvm:[51974] scummvm/trunk/engines/scumm

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Wed Aug 11 14:49:16 CEST 2010


Revision: 51974
          http://scummvm.svn.sourceforge.net/scummvm/?rev=51974&view=rev
Author:   fingolfin
Date:     2010-08-11 12:49:16 +0000 (Wed, 11 Aug 2010)

Log Message:
-----------
SCUMM: _resultVarNumber and related methods are specific to v0-v5

Modified Paths:
--------------
    scummvm/trunk/engines/scumm/script.cpp
    scummvm/trunk/engines/scumm/scumm.cpp
    scummvm/trunk/engines/scumm/scumm.h
    scummvm/trunk/engines/scumm/scumm_v5.h

Modified: scummvm/trunk/engines/scumm/script.cpp
===================================================================
--- scummvm/trunk/engines/scumm/script.cpp	2010-08-11 12:48:57 UTC (rev 51973)
+++ scummvm/trunk/engines/scumm/script.cpp	2010-08-11 12:49:16 UTC (rev 51974)
@@ -708,7 +708,7 @@
 	error("Illegal varbits (w)");
 }
 
-void ScummEngine::getResultPos() {
+void ScummEngine_v5::getResultPos() {
 	int a;
 
 	_resultVarNumber = fetchScriptWord();
@@ -723,7 +723,7 @@
 	}
 }
 
-void ScummEngine::setResult(int value) {
+void ScummEngine_v5::setResult(int value) {
 	writeVar(_resultVarNumber, value);
 }
 

Modified: scummvm/trunk/engines/scumm/scumm.cpp
===================================================================
--- scummvm/trunk/engines/scumm/scumm.cpp	2010-08-11 12:48:57 UTC (rev 51973)
+++ scummvm/trunk/engines/scumm/scumm.cpp	2010-08-11 12:49:16 UTC (rev 51974)
@@ -214,7 +214,6 @@
 	_opcode = 0;
 	vm.numNestedScripts = 0;
 	_lastCodePtr = NULL;
-	_resultVarNumber = 0;
 	_scummStackPos = 0;
 	memset(_vmStack, 0, sizeof(_vmStack));
 	_fileOffset = 0;
@@ -631,6 +630,10 @@
 	_flashlight.xStrips = 7;
 	_flashlight.yStrips = 7;
 	_flashlight.buffer = NULL;
+
+	memset(_saveLoadVarsFilename, 0, sizeof(_saveLoadVarsFilename));
+
+	_resultVarNumber = 0;
 }
 
 ScummEngine_v4::ScummEngine_v4(OSystem *syst, const DetectorResult &dr)

Modified: scummvm/trunk/engines/scumm/scumm.h
===================================================================
--- scummvm/trunk/engines/scumm/scumm.h	2010-08-11 12:48:57 UTC (rev 51973)
+++ scummvm/trunk/engines/scumm/scumm.h	2010-08-11 12:49:16 UTC (rev 51974)
@@ -689,7 +689,7 @@
 	const byte *_scriptPointer, *_scriptOrgPointer;
 	byte _opcode, _currentScript;
 	const byte * const *_lastCodePtr;
-	int _resultVarNumber, _scummStackPos;
+	int _scummStackPos;
 	int _vmStack[150];
 
 	OpcodeEntry _opcodes[256];
@@ -745,8 +745,6 @@
 	int fetchScriptDWordSigned();
 	void ignoreScriptWord() { fetchScriptWord(); }
 	void ignoreScriptByte() { fetchScriptByte(); }
-	virtual void getResultPos();
-	void setResult(int result);
 	void push(int a);
 	int pop();
 	virtual int readVar(uint var);

Modified: scummvm/trunk/engines/scumm/scumm_v5.h
===================================================================
--- scummvm/trunk/engines/scumm/scumm_v5.h	2010-08-11 12:48:57 UTC (rev 51973)
+++ scummvm/trunk/engines/scumm/scumm_v5.h	2010-08-11 12:49:16 UTC (rev 51974)
@@ -50,6 +50,8 @@
 		PARAM_3 = 0x20
 	};
 
+	int _resultVarNumber;
+
 public:
 	ScummEngine_v5(OSystem *syst, const DetectorResult &dr);
 
@@ -77,6 +79,9 @@
 	virtual int getVarOrDirectByte(byte mask);
 	virtual int getVarOrDirectWord(byte mask);
 
+	virtual void getResultPos();
+	void setResult(int result);
+
 	virtual void animateCursor();
 
 	virtual void setBuiltinCursor(int index);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list