[Scummvm-cvs-logs] SF.net SVN: scummvm:[52218] scummvm/trunk/engines/sci/graphics/view.cpp

[m_kiewitz at users.sourceforge.net]

Revision: 52218
          http://scummvm.svn.sourceforge.net/scummvm/?rev=52218&view=rev
Author:   m_kiewitz
Date:     2010-08-19 22:21:03 +0000 (Thu, 19 Aug 2010)

Log Message:
-----------
SCI: disabling EGA mapping after sci1ega

fixes vga conversion games graphic glitches, some views have bad mapping tables

Modified Paths:
--------------
    scummvm/trunk/engines/sci/graphics/view.cpp

Modified: scummvm/trunk/engines/sci/graphics/view.cpp
===================================================================
--- scummvm/trunk/engines/sci/graphics/view.cpp	2010-08-19 21:32:54 UTC (rev 52217)
+++ scummvm/trunk/engines/sci/graphics/view.cpp	2010-08-19 22:21:03 UTC (rev 52218)
@@ -128,8 +128,11 @@
 				_palette->createFromData(&_resourceData[palOffset], _resourceSize - palOffset, &_viewPalette);
 				_embeddedPal = true;
 			} else {
-				// Only use the EGA-mapping, when being SCI1
-				if (getSciVersion() >= SCI_VERSION_1_EGA) {
+				// Only use the EGA-mapping, when being SCI1 EGA
+				//  SCI1 VGA conversion games (which will get detected as SCI1EARLY/MIDDLE/LATE) have some views
+				//  with broken mapping tables. I guess those games won't use the mapping, so I rather disable it
+				//  for them
+				if (getSciVersion() == SCI_VERSION_1_EGA) {
 					_EGAmapping = &_resourceData[palOffset];
 					for (EGAmapNr = 0; EGAmapNr < SCI_VIEW_EGAMAPPING_COUNT; EGAmapNr++) {
 						if (memcmp(_EGAmapping, EGAmappingStraight, SCI_VIEW_EGAMAPPING_SIZE) != 0)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.