[Scummvm-cvs-logs] SF.net SVN: scummvm:[55070] scummvm/trunk/engines/cine/sound.cpp

[tdhs at users.sourceforge.net]

Revision: 55070
          http://scummvm.svn.sourceforge.net/scummvm/?rev=55070&view=rev
Author:   tdhs
Date:     2010-12-31 09:07:44 +0000 (Fri, 31 Dec 2010)

Log Message:
-----------
CINE: Close Memory Leak in PCSoundFxPlayer.

This leakage was reported by Valgrind while playing Operation Stealth.

Modified Paths:
--------------
    scummvm/trunk/engines/cine/sound.cpp

Modified: scummvm/trunk/engines/cine/sound.cpp
===================================================================
--- scummvm/trunk/engines/cine/sound.cpp	2010-12-30 22:43:20 UTC (rev 55069)
+++ scummvm/trunk/engines/cine/sound.cpp	2010-12-31 09:07:44 UTC (rev 55070)
@@ -575,9 +575,7 @@
 
 PCSoundFxPlayer::~PCSoundFxPlayer() {
 	_driver->setUpdateCallback(NULL, NULL);
-	if (_playing) {
-		stop();
-	}
+	stop();
 }
 
 bool PCSoundFxPlayer::load(const char *song) {
@@ -589,9 +587,7 @@
 	}
 	_fadeOutCounter = 0;
 
-	if (_playing) {
-		stop();
-	}
+	stop();
 
 	_sfxData = readBundleSoundFile(song);
 	if (!_sfxData) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.