[Scummvm-cvs-logs] SF.net SVN: scummvm:[47919] scummvm/trunk/engines/sci/graphics/compare.cpp

[fingolfin at users.sourceforge.net]

Revision: 47919
          http://scummvm.svn.sourceforge.net/scummvm/?rev=47919&view=rev
Author:   fingolfin
Date:     2010-02-05 22:55:41 +0000 (Fri, 05 Feb 2010)

Log Message:
-----------
SCI: Add comment to GfxCompare::canBeHereCheckRectList

Modified Paths:
--------------
    scummvm/trunk/engines/sci/graphics/compare.cpp

Modified: scummvm/trunk/engines/sci/graphics/compare.cpp
===================================================================
--- scummvm/trunk/engines/sci/graphics/compare.cpp	2010-02-05 22:55:18 UTC (rev 47918)
+++ scummvm/trunk/engines/sci/graphics/compare.cpp	2010-02-05 22:55:41 UTC (rev 47919)
@@ -93,6 +93,11 @@
 				curRect.right = GET_SEL32V(_segMan, curObject, SELECTOR(brRight));
 				curRect.bottom = GET_SEL32V(_segMan, curObject, SELECTOR(brBottom));
 				// Check if curRect is within checkRect
+				// TODO: This check is slightly odd, because it means that a rect is not contained
+				// in itself. It may very well be that the original SCI engine did it just
+				// this way, so it should not be changed lightly. However, somebody should
+				// confirm whether the original engine really did it this way. Then, update
+				// this comment accordingly, and, if necessary, fix the code.
 				if (curRect.right > checkRect.left &&
 				    curRect.left < checkRect.right &&
 				    curRect.bottom > checkRect.top &&


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.