[Scummvm-cvs-logs] SF.net SVN: scummvm:[47932] scummvm/trunk/engines/sci/graphics/compare.cpp

thebluegr at users.sourceforge.net thebluegr at users.sourceforge.net
Sat Feb 6 17:30:32 CET 2010


Revision: 47932
          http://scummvm.svn.sourceforge.net/scummvm/?rev=47932&view=rev
Author:   thebluegr
Date:     2010-02-06 16:30:32 +0000 (Sat, 06 Feb 2010)

Log Message:
-----------
Mark the sanity checks inside kernelSetNowSeen and kernelBaseSetter as hacks

Modified Paths:
--------------
    scummvm/trunk/engines/sci/graphics/compare.cpp

Modified: scummvm/trunk/engines/sci/graphics/compare.cpp
===================================================================
--- scummvm/trunk/engines/sci/graphics/compare.cpp	2010-02-06 16:12:19 UTC (rev 47931)
+++ scummvm/trunk/engines/sci/graphics/compare.cpp	2010-02-06 16:30:32 UTC (rev 47932)
@@ -116,6 +116,8 @@
 	GfxView *view = NULL;
 	Common::Rect celRect(0, 0);
 	GuiResourceId viewId = (GuiResourceId)GET_SEL32V(_segMan, objectReference, SELECTOR(view));
+
+	// HACK: Ignore invalid views for now (perhaps unimplemented text views?)
 	if (viewId == 0xFFFF)	// invalid view
 		return;
 
@@ -185,6 +187,7 @@
 		int16 loopNo = GET_SEL32V(_segMan, object, SELECTOR(loop));
 		int16 celNo = GET_SEL32V(_segMan, object, SELECTOR(cel));
 
+		// HACK: Ignore invalid views for now (perhaps unimplemented text views?)
 		if (viewId == 0xFFFF)	// invalid view
 			return;
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list