[Scummvm-cvs-logs] SF.net SVN: scummvm:[47973] scummvm/trunk/engines/sci/engine/features.cpp
mthreepwood at users.sourceforge.net
mthreepwood at users.sourceforge.net
Sun Feb 7 18:18:14 CET 2010
Revision: 47973
http://scummvm.svn.sourceforge.net/scummvm/?rev=47973&view=rev
Author: mthreepwood
Date: 2010-02-07 17:18:14 +0000 (Sun, 07 Feb 2010)
Log Message:
-----------
Update comments in autoDetectSci21KernelType() explaining what we're checking for.
Modified Paths:
--------------
scummvm/trunk/engines/sci/engine/features.cpp
Modified: scummvm/trunk/engines/sci/engine/features.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/features.cpp 2010-02-07 17:16:30 UTC (rev 47972)
+++ scummvm/trunk/engines/sci/engine/features.cpp 2010-02-07 17:18:14 UTC (rev 47973)
@@ -394,8 +394,10 @@
if (opcode == op_callk) {
uint16 kFuncNum = opparams[0];
- // TODO: Explain this check; what are those kernel funcs supposed
- // to be, why does this check work like it does?
+ // Here we check for the kDoSound opcode that's used in SCI2.1.
+ // Finding 0x40 as kDoSound in the Sound::play() function means the game is using
+ // the modified SCI2 kernel table found in some older SCI2.1 games (GK2 demo, KQ7 v1.4).
+ // Finding 0x75 as kDoSound means the game is using the regular SCI2.1 kernel table.
if (kFuncNum == 0x40) {
_sci21KernelType = SCI_VERSION_2;
return true;
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
More information about the Scummvm-git-logs
mailing list