[Scummvm-cvs-logs] SF.net SVN: scummvm:[48102] scummvm/trunk/engines/sci/graphics/compare.cpp

m_kiewitz at users.sourceforge.net m_kiewitz at users.sourceforge.net
Sun Feb 21 10:52:45 CET 2010


Revision: 48102
          http://scummvm.svn.sourceforge.net/scummvm/?rev=48102&view=rev
Author:   m_kiewitz
Date:     2010-02-21 09:52:44 +0000 (Sun, 21 Feb 2010)

Log Message:
-----------
SCI: added warning when getting invalid rect in kCan(t)BeHere

Modified Paths:
--------------
    scummvm/trunk/engines/sci/graphics/compare.cpp

Modified: scummvm/trunk/engines/sci/graphics/compare.cpp
===================================================================
--- scummvm/trunk/engines/sci/graphics/compare.cpp	2010-02-21 04:04:13 UTC (rev 48101)
+++ scummvm/trunk/engines/sci/graphics/compare.cpp	2010-02-21 09:52:44 UTC (rev 48102)
@@ -152,8 +152,10 @@
 	checkRect.right = GET_SEL32V(_segMan, curObject, SELECTOR(brRight));
 	checkRect.bottom = GET_SEL32V(_segMan, curObject, SELECTOR(brBottom));
 
-	if (!checkRect.isValidRect())	// can occur in Iceman
+	if (!checkRect.isValidRect()) {	// can occur in Iceman - HACK? TODO: is this really occuring in sierra sci? check this
+		warning("kCan(t)BeHere - invalid rect %d, %d -> %d, %d", checkRect.left, checkRect.top, checkRect.right, checkRect.bottom);
 		return false;
+	}
 
 	adjustedRect = _coordAdjuster->onControl(checkRect);
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list