[Scummvm-cvs-logs] SF.net SVN: scummvm:[47452] scummvm/trunk/engines/agos/sound.cpp

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Sat Jan 23 00:59:16 CET 2010


Revision: 47452
          http://scummvm.svn.sourceforge.net/scummvm/?rev=47452&view=rev
Author:   fingolfin
Date:     2010-01-22 23:59:16 +0000 (Fri, 22 Jan 2010)

Log Message:
-----------
AGOS: Add FIXME for a memory leak

Modified Paths:
--------------
    scummvm/trunk/engines/agos/sound.cpp

Modified: scummvm/trunk/engines/agos/sound.cpp
===================================================================
--- scummvm/trunk/engines/agos/sound.cpp	2010-01-22 23:58:24 UTC (rev 47451)
+++ scummvm/trunk/engines/agos/sound.cpp	2010-01-22 23:59:16 UTC (rev 47452)
@@ -602,6 +602,9 @@
 	if (_effects)
 		_effects->close();
 
+	// FIXME: _effects is leaked here! However, we can't just
+	// delete it, because this would delete the gameFile object,
+	// held by the current _effects object.
 	if (_vm->getPlatform() == Common::kPlatformWindows)
 		_effects = new WavSound(_mixer, gameFile, base);
 	else


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list