[Scummvm-cvs-logs] SF.net SVN: scummvm:[47685] scummvm/trunk/engines/kyra
lordhoto at users.sourceforge.net
lordhoto at users.sourceforge.net
Fri Jan 29 23:43:23 CET 2010
Revision: 47685
http://scummvm.svn.sourceforge.net/scummvm/?rev=47685&view=rev
Author: lordhoto
Date: 2010-01-29 22:43:23 +0000 (Fri, 29 Jan 2010)
Log Message:
-----------
Fix use of undefined behavior. (Thanks to syke for reporting)
Modified Paths:
--------------
scummvm/trunk/engines/kyra/animator_hof.cpp
scummvm/trunk/engines/kyra/animator_mr.cpp
scummvm/trunk/engines/kyra/gui_lok.cpp
scummvm/trunk/engines/kyra/gui_lol.cpp
scummvm/trunk/engines/kyra/sequences_hof.cpp
scummvm/trunk/engines/kyra/sound_towns.cpp
scummvm/trunk/engines/kyra/sprites_lol.cpp
Modified: scummvm/trunk/engines/kyra/animator_hof.cpp
===================================================================
--- scummvm/trunk/engines/kyra/animator_hof.cpp 2010-01-29 22:29:03 UTC (rev 47684)
+++ scummvm/trunk/engines/kyra/animator_hof.cpp 2010-01-29 22:43:23 UTC (rev 47685)
@@ -123,7 +123,7 @@
const ItemAnimData_v2 *s = &_itemAnimData[_nextAnimItem];
ActiveItemAnim *a = &_activeItemAnim[_nextAnimItem];
- _nextAnimItem = ++_nextAnimItem % _itemAnimDataSize;
+ _nextAnimItem = (_nextAnimItem + 1) % _itemAnimDataSize;
uint32 ctime = _system->getMillis();
if (ctime < a->nextFrame)
@@ -168,7 +168,7 @@
if (nextFrame) {
a->nextFrame = _system->getMillis() + (s->frames[a->currentFrame].delay * _tickLength);
- a->currentFrame = ++a->currentFrame % s->numFrames;
+ a->currentFrame = (a->currentFrame + 1) % s->numFrames;
}
}
Modified: scummvm/trunk/engines/kyra/animator_mr.cpp
===================================================================
--- scummvm/trunk/engines/kyra/animator_mr.cpp 2010-01-29 22:29:03 UTC (rev 47684)
+++ scummvm/trunk/engines/kyra/animator_mr.cpp 2010-01-29 22:43:23 UTC (rev 47685)
@@ -193,7 +193,7 @@
const ItemAnimData_v2 *s = &_itemAnimData[_nextAnimItem];
ActiveItemAnim *a = &_activeItemAnim[_nextAnimItem];
- _nextAnimItem = ++_nextAnimItem % 10;
+ _nextAnimItem = (_nextAnimItem + 1) % 10;
uint32 ctime = _system->getMillis();
if (ctime < a->nextFrame)
@@ -232,7 +232,7 @@
if (nextFrame) {
a->nextFrame = _system->getMillis() + (s->frames[a->currentFrame].delay * _tickLength);
- a->currentFrame = ++a->currentFrame % s->numFrames;
+ a->currentFrame = (a->currentFrame + 1) % s->numFrames;
}
}
Modified: scummvm/trunk/engines/kyra/gui_lok.cpp
===================================================================
--- scummvm/trunk/engines/kyra/gui_lok.cpp 2010-01-29 22:29:03 UTC (rev 47684)
+++ scummvm/trunk/engines/kyra/gui_lok.cpp 2010-01-29 22:43:23 UTC (rev 47685)
@@ -1008,7 +1008,7 @@
int GUI_LoK::controlsChangeMusic(Button *button) {
updateMenuButton(button);
- _vm->_configMusic = ++_vm->_configMusic % ((_vm->gameFlags().platform == Common::kPlatformFMTowns) ? 3 : 2);
+ _vm->_configMusic = (_vm->_configMusic + 1) % ((_vm->gameFlags().platform == Common::kPlatformFMTowns) ? 3 : 2);
setupControls(_menu[5]);
return 0;
}
@@ -1024,7 +1024,7 @@
int GUI_LoK::controlsChangeWalk(Button *button) {
updateMenuButton(button);
- _vm->_configWalkspeed = ++_vm->_configWalkspeed % 5;
+ _vm->_configWalkspeed = (_vm->_configWalkspeed + 1) % 5;
_vm->setWalkspeed(_vm->_configWalkspeed);
setupControls(_menu[5]);
return 0;
@@ -1033,7 +1033,7 @@
int GUI_LoK::controlsChangeText(Button *button) {
updateMenuButton(button);
- _vm->_configTextspeed = ++_vm->_configTextspeed % 4;
+ _vm->_configTextspeed = (_vm->_configTextspeed + 1) % 4;
setupControls(_menu[5]);
return 0;
}
@@ -1041,7 +1041,7 @@
int GUI_LoK::controlsChangeVoice(Button *button) {
updateMenuButton(button);
- _vm->_configVoice = ++_vm->_configVoice % 3;
+ _vm->_configVoice = (_vm->_configVoice + 1) % 3;
setupControls(_menu[5]);
return 0;
}
Modified: scummvm/trunk/engines/kyra/gui_lol.cpp
===================================================================
--- scummvm/trunk/engines/kyra/gui_lol.cpp 2010-01-29 22:29:03 UTC (rev 47684)
+++ scummvm/trunk/engines/kyra/gui_lol.cpp 2010-01-29 22:43:23 UTC (rev 47685)
@@ -1059,7 +1059,7 @@
return 0;
gui_toggleButtonDisplayMode(_flags.isTalkie ? 79 : 77, 1);
- _currentDirection = (--_currentDirection) & 3;
+ _currentDirection = (_currentDirection - 1) & 3;
_sceneDefaultUpdate = 1;
@@ -1081,7 +1081,7 @@
return 0;
gui_toggleButtonDisplayMode(_flags.isTalkie ? 81 : 79, 1);
- _currentDirection = (++_currentDirection) & 3;
+ _currentDirection = (_currentDirection + 1) & 3;
_sceneDefaultUpdate = 1;
@@ -2801,7 +2801,7 @@
_vm->sound()->enableSFX(_vm->_configSounds);
break;
case 0xfff7:
- _vm->_monsterDifficulty = ++_vm->_monsterDifficulty % 3;
+ _vm->_monsterDifficulty = (_vm->_monsterDifficulty + 1) % 3;
break;
case 0xfff6:
_vm->_smoothScrollingEnabled ^= true;
Modified: scummvm/trunk/engines/kyra/sequences_hof.cpp
===================================================================
--- scummvm/trunk/engines/kyra/sequences_hof.cpp 2010-01-29 22:29:03 UTC (rev 47684)
+++ scummvm/trunk/engines/kyra/sequences_hof.cpp 2010-01-29 22:43:23 UTC (rev 47685)
@@ -2716,7 +2716,7 @@
_screen->fillRect(12, def->y - 8, 28, def->y + 8, 0, 4);
_screen->drawShape(4, getShapePtr(def->itemIndex + def->frames[a->currentFrame]), 12, def->y - 8, 0, 0);
if (_seqFrameCounter % 2 == 0)
- a->currentFrame = ++a->currentFrame % 20;
+ a->currentFrame = (a->currentFrame + 1) % 20;
}
}
_screen->copyRegionEx(4, 0, srcH, 2, 2, dstY + bottom, 320, dstH, &d);
Modified: scummvm/trunk/engines/kyra/sound_towns.cpp
===================================================================
--- scummvm/trunk/engines/kyra/sound_towns.cpp 2010-01-29 22:29:03 UTC (rev 47684)
+++ scummvm/trunk/engines/kyra/sound_towns.cpp 2010-01-29 22:43:23 UTC (rev 47685)
@@ -2144,7 +2144,7 @@
bool TownsPC98_OpnChannel::control_fd_jump(uint8 para) {
uint8 *tmp = _drv->_trackPtr + READ_LE_UINT16(_dataPtr - 1);
- _dataPtr = (tmp[1] == 1) ? tmp : ++_dataPtr;
+ _dataPtr = (tmp[1] == 1) ? tmp : (_dataPtr + 1);
return true;
}
Modified: scummvm/trunk/engines/kyra/sprites_lol.cpp
===================================================================
--- scummvm/trunk/engines/kyra/sprites_lol.cpp 2010-01-29 22:29:03 UTC (rev 47684)
+++ scummvm/trunk/engines/kyra/sprites_lol.cpp 2010-01-29 22:43:23 UTC (rev 47685)
@@ -270,7 +270,7 @@
if (monster->x != x || monster->y != y) {
monster->x = x;
monster->y = y;
- monster->currentSubFrame = (++monster->currentSubFrame) & 3;
+ monster->currentSubFrame = (monster->currentSubFrame + 1) & 3;
}
if (monster->block == 0)
@@ -1115,7 +1115,7 @@
if ((monster->mode != 11) && (monster->mode != 14)) {
if (!(_rnd.getRandomNumber(255) & 3)) {
- monster->shiftStep = (++monster->shiftStep) & 0x0f;
+ monster->shiftStep = (monster->shiftStep + 1) & 0x0f;
checkSceneUpdateNeed(monster->block);
}
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
More information about the Scummvm-git-logs
mailing list