[Scummvm-cvs-logs] SF.net SVN: scummvm:[51007] scummvm/trunk/engines/sci/detection.cpp

m_kiewitz at users.sourceforge.net m_kiewitz at users.sourceforge.net
Sun Jul 18 21:19:50 CEST 2010


Revision: 51007
          http://scummvm.svn.sourceforge.net/scummvm/?rev=51007&view=rev
Author:   m_kiewitz
Date:     2010-07-18 19:19:49 +0000 (Sun, 18 Jul 2010)

Log Message:
-----------
SCI: adding comments about not enabling ScummVM menu saving

Modified Paths:
--------------
    scummvm/trunk/engines/sci/detection.cpp

Modified: scummvm/trunk/engines/sci/detection.cpp
===================================================================
--- scummvm/trunk/engines/sci/detection.cpp	2010-07-18 19:01:35 UTC (rev 51006)
+++ scummvm/trunk/engines/sci/detection.cpp	2010-07-18 19:19:49 UTC (rev 51007)
@@ -628,6 +628,13 @@
 		//(f == kSupportsRTL) ||
 		(f == kSupportsLoadingDuringRuntime); // ||
 		//(f == kSupportsSavingDuringRuntime);
+		// We can't allow saving through ScummVM menu, because
+		//  a) lots of games don't like saving everywhere (e.g. castle of dr. brain)
+		//  b) some games even dont allow saving in certain rooms (e.g. lsl6)
+		//  c) somehow some games even get mad when doing this (execstackbase was 1 all of a sudden in lsl3)
+		//  d) for sci0/sci01 games we should at least wait till status bar got drawn, although this may not be enough
+		// we can't make sure that the scripts are fine with us saving at a specific location, doing so may work sometimes
+		//  and some other times it won't work.
 }
 
 SaveStateList SciMetaEngine::listSaves(const char *target) const {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list