[Scummvm-cvs-logs] SF.net SVN: scummvm:[51499] scummvm/trunk/engines/sci/engine

[thebluegr at users.sourceforge.net]

Revision: 51499
          http://scummvm.svn.sourceforge.net/scummvm/?rev=51499&view=rev
Author:   thebluegr
Date:     2010-07-30 07:11:57 +0000 (Fri, 30 Jul 2010)

Log Message:
-----------
SCI: Updated some comments related to Freddy Pharkas and silenced warning for kDoAudio subop 13

Modified Paths:
--------------
    scummvm/trunk/engines/sci/engine/kgraphics.cpp
    scummvm/trunk/engines/sci/engine/ksound.cpp

Modified: scummvm/trunk/engines/sci/engine/kgraphics.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/kgraphics.cpp	2010-07-30 07:05:40 UTC (rev 51498)
+++ scummvm/trunk/engines/sci/engine/kgraphics.cpp	2010-07-30 07:11:57 UTC (rev 51499)
@@ -177,7 +177,7 @@
 	case 10:	// Freddy Pharkas, when using the whiskey glass to read
 				// the prescription (bug #3034973) - looks like an erroneous
 				// extra param
-		// TODO: We don't really use parameter indices 6-10 (with no side
+		// TODO: We don't really use parameter indices 5-9 (with no side
 		// effects), are they used for something, or are these a result of
 		// script bugs?
 		hotspot = new Common::Point(argv[3].toSint16(), argv[4].toSint16());

Modified: scummvm/trunk/engines/sci/engine/ksound.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/ksound.cpp	2010-07-30 07:05:40 UTC (rev 51498)
+++ scummvm/trunk/engines/sci/engine/ksound.cpp	2010-07-30 07:11:57 UTC (rev 51499)
@@ -222,16 +222,17 @@
 
 		// 3 new subops in Pharkas. kDoAudio in Pharkas sits at seg026:038C
 	case 11:
+		// Not sure where this is used yet
 		warning("kDoAudio: Unhandled case 11, %d extra arguments passed", argc - 1);
 		break;
 	case 12:
-		// Seems to be audio sync, used in Pharkas. Silenced the warning due to
-		// the high level of spam it produces.
+		// Seems to be some sort of audio sync, used in Pharkas. Silenced the
+		// warning due to the high level of spam it produces. (takes no params)
 		//warning("kDoAudio: Unhandled case 12, %d extra arguments passed", argc - 1);
 		break;
 	case 13:
-		// Used in Pharkas whenever a speech sample starts
-		warning("kDoAudio: Unhandled case 13, %d extra arguments passed", argc - 1);
+		// Used in Pharkas whenever a speech sample starts (takes no params)
+		//warning("kDoAudio: Unhandled case 13, %d extra arguments passed", argc - 1);
 		break;
 	default:
 		warning("kDoAudio: Unhandled case %d, %d extra arguments passed", argv[0].toUint16(), argc - 1);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.