[Scummvm-cvs-logs] SF.net SVN: scummvm:[51523] scummvm/trunk/engines/sci/graphics/animate.cpp

[lordhoto at users.sourceforge.net]

Revision: 51523
          http://scummvm.svn.sourceforge.net/scummvm/?rev=51523&view=rev
Author:   lordhoto
Date:     2010-07-30 23:24:45 +0000 (Fri, 30 Jul 2010)

Log Message:
-----------
SCI: Add comment about stability requirements in makeSortedList.

Modified Paths:
--------------
    scummvm/trunk/engines/sci/graphics/animate.cpp

Modified: scummvm/trunk/engines/sci/graphics/animate.cpp
===================================================================
--- scummvm/trunk/engines/sci/graphics/animate.cpp	2010-07-30 23:24:22 UTC (rev 51522)
+++ scummvm/trunk/engines/sci/graphics/animate.cpp	2010-07-30 23:24:45 UTC (rev 51523)
@@ -177,6 +177,12 @@
 		curNode = _s->_segMan->lookupNode(curAddress);
 	}
 
+	// Possible TODO: As noted in the comment in sortHelper we actually
+	// require a stable sorting algorithm here. Since Common::sort is not stable
+	// at the time of writing this comment, we work around that in our ordering
+	// comparator. If that changes in the future or we want to use some
+	// stable sorting algorithm here, we should change that.
+
 	// Now sort the list according y and z (descending)
 	Common::sort(_list.begin(), _list.end(), sortHelper);
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.