[Scummvm-cvs-logs] SF.net SVN: scummvm:[51554] tools/branches/gsoc2010-decompiler/decompiler/ scummv6/disassembler.cpp

[pidgeot at users.sourceforge.net]

Revision: 51554
          http://scummvm.svn.sourceforge.net/scummvm/?rev=51554&view=rev
Author:   pidgeot
Date:     2010-07-31 21:47:56 +0000 (Sat, 31 Jul 2010)

Log Message:
-----------
Add FIXME/TODO comment to beginOverride

Modified Paths:
--------------
    tools/branches/gsoc2010-decompiler/decompiler/scummv6/disassembler.cpp

Modified: tools/branches/gsoc2010-decompiler/decompiler/scummv6/disassembler.cpp
===================================================================
--- tools/branches/gsoc2010-decompiler/decompiler/scummv6/disassembler.cpp	2010-07-31 21:42:17 UTC (rev 51553)
+++ tools/branches/gsoc2010-decompiler/decompiler/scummv6/disassembler.cpp	2010-07-31 21:47:56 UTC (rev 51554)
@@ -164,6 +164,11 @@
 		OPCODE_MD(0x94, "getVerbFromXY", kSpecial, -1, "", "rpp");
 		OPCODE_BASE(0x95)
 			OPCODE_BODY("beginOverride", kSpecial, 0, "", "");
+			// FIXME/TODO: beginOverride skips the following jump - that jump is instead to a "finally" handler
+			// To simulate this, we simply skip the jump instruction, so the sequential order appears the same.
+			// Semantically, it would probably be more correct to model this as a conditional jump,
+			// but since precious little time remains of GSoC and that might not play very nice with the rest of the code,
+			// this is the simplest way to handle the issue right now. Eventually, it should probably be fixed more properly.
 			_f.seek(3, SEEK_CUR);
 			_address += 3;
 			OPCODE_END;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.