[Scummvm-cvs-logs] SF.net SVN: scummvm:[49524] tools/branches/gsoc2010-decompiler/decompiler

[pidgeot at users.sourceforge.net]

Revision: 49524
          http://scummvm.svn.sourceforge.net/scummvm/?rev=49524&view=rev
Author:   pidgeot
Date:     2010-06-08 22:14:48 +0000 (Tue, 08 Jun 2010)

Log Message:
-----------
Reference and constify a few methods

Modified Paths:
--------------
    tools/branches/gsoc2010-decompiler/decompiler/engine.h
    tools/branches/gsoc2010-decompiler/decompiler/objectFactory.h
    tools/branches/gsoc2010-decompiler/decompiler/scummv6/engine.cpp
    tools/branches/gsoc2010-decompiler/decompiler/scummv6/engine.h

Modified: tools/branches/gsoc2010-decompiler/decompiler/engine.h
===================================================================
--- tools/branches/gsoc2010-decompiler/decompiler/engine.h	2010-06-08 22:00:59 UTC (rev 49523)
+++ tools/branches/gsoc2010-decompiler/decompiler/engine.h	2010-06-08 22:14:48 UTC (rev 49524)
@@ -29,7 +29,7 @@
 public:
 	virtual ~Engine() {}
 
-	virtual Disassembler *getDisassembler() = 0;
+	virtual Disassembler *getDisassembler() const = 0;
 };
 
 #endif

Modified: tools/branches/gsoc2010-decompiler/decompiler/objectFactory.h
===================================================================
--- tools/branches/gsoc2010-decompiler/decompiler/objectFactory.h	2010-06-08 22:00:59 UTC (rev 49523)
+++ tools/branches/gsoc2010-decompiler/decompiler/objectFactory.h	2010-06-08 22:14:48 UTC (rev 49524)
@@ -54,7 +54,7 @@
 	 * @param name The name to register the class under.
 	 */
 	template<typename Type>
-	void addEntry(std::string name) {
+	void addEntry(const std::string &name) {
 		_registry[name] = &createObject<BaseType, Type>;
 	}
 
@@ -64,7 +64,7 @@
 	 * @param name The name associated with the desired class.
 	 * @return NULL if the name is not registered, else an instance of the associated class.
 	 */
-	BaseType *create(std::string name) const {
+	BaseType *create(const std::string &name) const {
 		typename RegistryMap::const_iterator entry = _registry.find(name);
 		if (entry == _registry.end())
 			return NULL;

Modified: tools/branches/gsoc2010-decompiler/decompiler/scummv6/engine.cpp
===================================================================
--- tools/branches/gsoc2010-decompiler/decompiler/scummv6/engine.cpp	2010-06-08 22:00:59 UTC (rev 49523)
+++ tools/branches/gsoc2010-decompiler/decompiler/scummv6/engine.cpp	2010-06-08 22:14:48 UTC (rev 49524)
@@ -23,6 +23,6 @@
 #include "engine.h"
 #include "disassembler.h"
 
-::Disassembler *Scumm::v6::Engine::getDisassembler() {
+::Disassembler *Scumm::v6::Engine::getDisassembler() const {
 	return new Disassembler();
 }

Modified: tools/branches/gsoc2010-decompiler/decompiler/scummv6/engine.h
===================================================================
--- tools/branches/gsoc2010-decompiler/decompiler/scummv6/engine.h	2010-06-08 22:00:59 UTC (rev 49523)
+++ tools/branches/gsoc2010-decompiler/decompiler/scummv6/engine.h	2010-06-08 22:14:48 UTC (rev 49524)
@@ -31,7 +31,7 @@
 
 class Engine : public ::Engine {
 public:
-	::Disassembler *getDisassembler();
+	::Disassembler *getDisassembler() const;
 };
 
 } //End of namespace Scumm::v6


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.