[Scummvm-cvs-logs] SF.net SVN: scummvm:[49849] scummvm/trunk/engines/sci

[fingolfin at users.sourceforge.net]

Revision: 49849
          http://scummvm.svn.sourceforge.net/scummvm/?rev=49849&view=rev
Author:   fingolfin
Date:     2010-06-15 12:35:39 +0000 (Tue, 15 Jun 2010)

Log Message:
-----------
SCI: Add FIXME regarding audio specific code in Resource(Source)

Modified Paths:
--------------
    scummvm/trunk/engines/sci/resource.h
    scummvm/trunk/engines/sci/resource_intern.h

Modified: scummvm/trunk/engines/sci/resource.h
===================================================================
--- scummvm/trunk/engines/sci/resource.h	2010-06-15 12:35:17 UTC (rev 49848)
+++ scummvm/trunk/engines/sci/resource.h	2010-06-15 12:35:39 UTC (rev 49849)
@@ -205,6 +205,10 @@
 	 * This method is used only by the "dump" debugger command.
 	 */
 	void writeToStream(Common::WriteStream *stream) const;
+
+	// FIXME: This audio specific method is a hack. After all, why should a
+	// Resource have audio specific methods? But for now we keep this, as it
+	// eases transition.
 	uint32 getAudioCompressionType() const;
 
 protected:

Modified: scummvm/trunk/engines/sci/resource_intern.h
===================================================================
--- scummvm/trunk/engines/sci/resource_intern.h	2010-06-15 12:35:17 UTC (rev 49848)
+++ scummvm/trunk/engines/sci/resource_intern.h	2010-06-15 12:35:39 UTC (rev 49849)
@@ -85,8 +85,10 @@
 	 */
 	virtual void loadResource(Resource *res);
 
+	// FIXME: This audio specific method is a hack. After all, why should a
+	// ResourceSource or a Resource (which uses this method) have audio
+	// specific methods? But for now we keep this, as it eases transition.
 	virtual uint32 getAudioCompressionType() const { return 0; }
-
 };
 
 class DirectoryResourceSource : public ResourceSource {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.