[Scummvm-cvs-logs] SF.net SVN: scummvm:[50456] scummvm/trunk/engines/sci/sound/midiparser_sci. cpp

m_kiewitz at users.sourceforge.net m_kiewitz at users.sourceforge.net
Mon Jun 28 22:17:43 CEST 2010


Revision: 50456
          http://scummvm.svn.sourceforge.net/scummvm/?rev=50456&view=rev
Author:   m_kiewitz
Date:     2010-06-28 20:17:43 +0000 (Mon, 28 Jun 2010)

Log Message:
-----------
SCI: remove clipping of volume inside SciMidiParser::setvolume

Modified Paths:
--------------
    scummvm/trunk/engines/sci/sound/midiparser_sci.cpp

Modified: scummvm/trunk/engines/sci/sound/midiparser_sci.cpp
===================================================================
--- scummvm/trunk/engines/sci/sound/midiparser_sci.cpp	2010-06-28 18:14:16 UTC (rev 50455)
+++ scummvm/trunk/engines/sci/sound/midiparser_sci.cpp	2010-06-28 20:17:43 UTC (rev 50456)
@@ -665,13 +665,6 @@
 }
 
 void MidiParser_SCI::setVolume(byte volume) {
-	// FIXME: This receives values > 127... throw a warning for now and clip the variable
-	if (volume > MUSIC_VOLUME_MAX) {
-		// FIXME: please write where we get an invalid volume, so we can track down the issue
-		error("attempted to set an invalid volume(%d)", volume);
-		volume = MUSIC_VOLUME_MAX;	// reset
-	}
-
 	assert(volume <= MUSIC_VOLUME_MAX);
 	_volume = volume;
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list