[Scummvm-cvs-logs] SF.net SVN: scummvm:[49115] scummvm/trunk/backends/platform/psp

[bluddy at users.sourceforge.net]

Revision: 49115
          http://scummvm.svn.sourceforge.net/scummvm/?rev=49115&view=rev
Author:   bluddy
Date:     2010-05-20 10:36:54 +0000 (Thu, 20 May 2010)

Log Message:
-----------
PSP: Had to switch to different way of using callbacks as last one wasn't working well. Seems to be working well this way, so I activated it. If need be, deactivate it by commenting out USE_DISPLAY_CALLBACK

Modified Paths:
--------------
    scummvm/trunk/backends/platform/psp/display_manager.cpp
    scummvm/trunk/backends/platform/psp/display_manager.h

Modified: scummvm/trunk/backends/platform/psp/display_manager.cpp
===================================================================
--- scummvm/trunk/backends/platform/psp/display_manager.cpp	2010-05-20 06:11:46 UTC (rev 49114)
+++ scummvm/trunk/backends/platform/psp/display_manager.cpp	2010-05-20 10:36:54 UTC (rev 49115)
@@ -35,7 +35,7 @@
 #include "backends/platform/psp/cursor.h"
 #include "backends/platform/psp/pspkeyboard.h"
 
-//#define USE_DISPLAY_CALLBACK	// to use callback for finishing the render
+#define USE_DISPLAY_CALLBACK	// to use callback for finishing the render
 #include "backends/platform/psp/display_manager.h"
 
 #define PSP_BUFFER_WIDTH (512)
@@ -60,8 +60,6 @@
 	{0, 0, 0}
 };
 
-bool MasterGuRenderer::_renderFinished = true;	// synchronizes the callback thread
-
 // Class MasterGuRenderer ----------------------------------------------
 
 void MasterGuRenderer::setupCallbackThread() {
@@ -70,33 +68,47 @@
 	
 	PSP_DEBUG_PRINT("Display CB thread id is %x\n", thid);
 	
+	// We want to pass the pointer to this, but we'll have to take address of this so use a little trick
+	MasterGuRenderer *_this = this;
+	
 	if (thid >= 0) {
-		sceKernelStartThread(thid, 0, 0);
+		sceKernelStartThread(thid, sizeof(uint32 *), &_this);
 	} else 
 		PSP_ERROR("failed to create display callback thread\n");
 }
 
 // thread that reacts to the callback
-int MasterGuRenderer::guCallbackThread(SceSize, void *) {
+int MasterGuRenderer::guCallbackThread(SceSize, void *__this) {
 	DEBUG_ENTER_FUNC();
 	
-	if (sceGuSetCallback(GU_CALLBACK_FINISH, guDisplayCallback) != 0) {
-		PSP_ERROR("Warning: previous display callback found.\n");
+	// Dereferenced the copied value which was this
+	MasterGuRenderer *_this = *(MasterGuRenderer **)__this;
+	
+	// Create the callback. It should always get the pointer to MasterGuRenderer
+	_this->_callbackId = sceKernelCreateCallback("Display Callback", guCallback, _this);
+	if (_this->_callbackId < 0) {
+		PSP_ERROR("failed to create display callback\n");
+		return -1;
 	}
-	PSP_DEBUG_PRINT("set callback. Going to sleep\n");
+	
+	PSP_DEBUG_PRINT("created callback. Going to sleep\n");
 
 	sceKernelSleepThreadCB();	// sleep until we get a callback
 	return 0;
 }
 
 // This callback is called when the render is finished. It swaps the buffers
-void MasterGuRenderer::guDisplayCallback(int) {
-	if (_renderFinished == true)
-		PSP_ERROR("callback thread found wrong value[true] in _renderFinished\n");
-		
-	sceDisplayWaitVblankStart();	// wait for v-blank without eating main thread cycles
-	sceGuSwapBuffers();
-	_renderFinished = true;	// Only this thread can set the variable to true
+int MasterGuRenderer::guCallback(int, int, void *__this) {
+
+	MasterGuRenderer *_this = (MasterGuRenderer *)__this;
+
+	sceGuSync(0, 0);				// make sure we wait for GU to finish		
+	sceDisplayWaitVblankStartCB();	// wait for v-blank without eating main thread cycles
+	sceGuSwapBuffers();				// swap the back and front buffers
+
+	_this->_renderFinished = true;	// Only this thread can set the variable to true
+	
+	return 0;
 }
 
 void MasterGuRenderer::guInit() {
@@ -174,7 +186,12 @@
 	DEBUG_ENTER_FUNC();
 
 	sceGuFinish();
-#ifndef USE_DISPLAY_CALLBACK
+#ifdef USE_DISPLAY_CALLBACK
+	if (_callbackId < 0)
+		PSP_ERROR("bad callbackId[%d]\n", _callbackId);
+	else
+		sceKernelNotifyCallback(_callbackId, 0);	// notify the callback. Nothing extra to pass
+#else
 	sceGuSync(0, 0);	
 
 #ifdef ENABLE_RENDER_MEASURE
@@ -209,7 +226,6 @@
 	_overlay->init();
 	_cursor->init();
 
-
 	_masterGuRenderer.guInit();				// start up the renderer
 #ifdef USE_DISPLAY_CALLBACK
 	_masterGuRenderer.setupCallbackThread();

Modified: scummvm/trunk/backends/platform/psp/display_manager.h
===================================================================
--- scummvm/trunk/backends/platform/psp/display_manager.h	2010-05-20 06:11:46 UTC (rev 49114)
+++ scummvm/trunk/backends/platform/psp/display_manager.h	2010-05-20 10:36:54 UTC (rev 49115)
@@ -31,7 +31,7 @@
  */
 class MasterGuRenderer {
 public:
-	MasterGuRenderer() : _lastRenderTime(0) {}
+	MasterGuRenderer() : _lastRenderTime(0), _renderFinished(true), _callbackId(-1) {}
 	void guInit();
 	void guPreRender();
 	void guPostRender();
@@ -42,9 +42,10 @@
 	static uint32 _displayList[];
 	uint32 _lastRenderTime;					// For measuring rendering
 	void guProgramDisplayBufferSizes();
-	static bool _renderFinished;
-	static int guCallbackThread(SceSize, void *);
-	static void guDisplayCallback(int);
+	static int guCallbackThread(SceSize, void *);	// for the graphics callbacks
+	static int guCallback(int, int, void *__this);
+	bool _renderFinished;
+	int _callbackId;
 };
 
 class Screen;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.