[Scummvm-cvs-logs] SF.net SVN: scummvm:[49227] scummvm/trunk/engines/sci

[thebluegr at users.sourceforge.net]

Revision: 49227
          http://scummvm.svn.sourceforge.net/scummvm/?rev=49227&view=rev
Author:   thebluegr
Date:     2010-05-26 06:53:08 +0000 (Wed, 26 May 2010)

Log Message:
-----------
Cleanup

Modified Paths:
--------------
    scummvm/trunk/engines/sci/engine/savegame.cpp
    scummvm/trunk/engines/sci/resource.cpp

Modified: scummvm/trunk/engines/sci/engine/savegame.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/savegame.cpp	2010-05-26 06:45:57 UTC (rev 49226)
+++ scummvm/trunk/engines/sci/engine/savegame.cpp	2010-05-26 06:53:08 UTC (rev 49227)
@@ -849,24 +849,19 @@
 			byte *data = scr->_buf + it->_value.getPos().offset;
 
 			if (getSciVersion() >= SCI_VERSION_1_1) {
-				uint16 *funct_area = (uint16 *)(scr->_buf + READ_LE_UINT16( data + 6 ));
-				uint16 *prop_area = (uint16 *)(scr->_buf + READ_LE_UINT16( data + 4 ));
-
-				it->_value._baseMethod = funct_area;
-				it->_value._baseVars = prop_area;
+				it->_value._baseMethod = (uint16 *)(scr->_buf + READ_LE_UINT16( data + 6 ));
+				it->_value._baseVars = (uint16 *)(scr->_buf + READ_LE_UINT16( data + 4 ));
 			} else {
 				int funct_area = READ_LE_UINT16(data + SCRIPT_FUNCTAREAPTR_OFFSET);
-				Object *_baseObj;
+				Object *baseObj = s->_segMan->getObject(it->_value.getSpeciesSelector());
 
-				_baseObj = s->_segMan->getObject(it->_value.getSpeciesSelector());
-
-				if (!_baseObj) {
+				if (!baseObj) {
 					warning("Object without a base class: Script %d, index %d (reg address %04x:%04x",
 						  scr->_nr, i, PRINT_REG(it->_value.getSpeciesSelector()));
 					continue;
 				}
-				it->_value.setVarCount(_baseObj->getVarCount());
-				it->_value._baseObj = _baseObj->_baseObj;
+				it->_value.setVarCount(baseObj->getVarCount());
+				it->_value._baseObj = baseObj->_baseObj;
 
 				it->_value._baseMethod = (uint16 *)(data + funct_area);
 				it->_value._baseVars = (uint16 *)(data + it->_value.getVarCount() * 2 + SCRIPT_SELECTOR_OFFSET);

Modified: scummvm/trunk/engines/sci/resource.cpp
===================================================================
--- scummvm/trunk/engines/sci/resource.cpp	2010-05-26 06:45:57 UTC (rev 49226)
+++ scummvm/trunk/engines/sci/resource.cpp	2010-05-26 06:53:08 UTC (rev 49227)
@@ -2343,6 +2343,7 @@
 	// In SCI0-SCI1, the heap is embedded in the script. In SCI1.1+, it's separated
 	Resource *heap = 0;
 	byte *seeker = 0;
+	Common::String sierraId;
 
 	// Seek to the name selector of the first export
 	if (getSciVersion() < SCI_VERSION_1_1) {
@@ -2357,14 +2358,12 @@
 		seeker = heap->data + READ_UINT16(heap->data + READ_UINT16(exportPtr) + nameSelector * 2);
 	}
 
-	char sierraId[20];
-	int i = 0;
-	byte curChar = 0;
+	char c = 0;
 
 	do {
-		curChar = *(seeker + i);
-		sierraId[i++] = curChar;
-	} while (curChar != 0);
+		c = *(seeker++);
+		sierraId += c;
+	} while (c);
 
 	return sierraId;
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.