[Scummvm-cvs-logs] SF.net SVN: scummvm:[49320] scummvm/trunk/engines/sci/engine/segment.cpp

[lskovlun at users.sourceforge.net]

Revision: 49320
          http://scummvm.svn.sourceforge.net/scummvm/?rev=49320&view=rev
Author:   lskovlun
Date:     2010-05-30 10:27:39 +0000 (Sun, 30 May 2010)

Log Message:
-----------
Clarify reasoning behind hack in Script::scriptRelocate()

Modified Paths:
--------------
    scummvm/trunk/engines/sci/engine/segment.cpp

Modified: scummvm/trunk/engines/sci/engine/segment.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/segment.cpp	2010-05-30 09:47:00 UTC (rev 49319)
+++ scummvm/trunk/engines/sci/engine/segment.cpp	2010-05-30 10:27:39 UTC (rev 49320)
@@ -270,8 +270,14 @@
 
 	for (int i = 0; i <= count; i++) {
 		int pos = READ_SCI11ENDIAN_UINT16(_buf + block.offset + 2 + (i * 2));
+		// This occurs in SCI01/SCI1 games where every other export
+		// value is zero. I have no idea what it's supposed to mean.
+		//
+		// Yes, there is code in the original to handle this situation,
+		// but we need an example of it happening in order to determine
+		// what to do.
 		if (!pos)
-			continue; // FIXME: A hack pending investigation
+			continue; // FIXME: Just ignore it for now.
 
 		if (!relocateLocal(block.segment, pos)) {
 			bool done = false;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.