[Scummvm-cvs-logs] SF.net SVN: scummvm:[54005] scummvm/trunk/backends/platform/symbian/src/ portdefs.h

[fingolfin at users.sourceforge.net]

Revision: 54005
          http://scummvm.svn.sourceforge.net/scummvm/?rev=54005&view=rev
Author:   fingolfin
Date:     2010-11-01 16:02:47 +0000 (Mon, 01 Nov 2010)

Log Message:
-----------
SYMBIAN: Trigger a compiler error on systems where __GCC32__ is set, instead of producing incorrect code

Modified Paths:
--------------
    scummvm/trunk/backends/platform/symbian/src/portdefs.h

Modified: scummvm/trunk/backends/platform/symbian/src/portdefs.h
===================================================================
--- scummvm/trunk/backends/platform/symbian/src/portdefs.h	2010-11-01 16:02:28 UTC (rev 54004)
+++ scummvm/trunk/backends/platform/symbian/src/portdefs.h	2010-11-01 16:02:47 UTC (rev 54005)
@@ -45,6 +45,13 @@
 // and we _really_ don't wanna link with any other windows LIBC library!
 #if defined(__GCC32__)
 
+	FIXME: If the following macros are ever used, then this will lead
+	to serious errors, e.g. an almost guaranteed buffer overflow
+	in Common::String::format(). Do *NOT* re-#define vsnprintf to
+	vsprintf, it will lead to disaster!
+	This shouldn't be necessary anyway, since we have
+	backends/platform/symbian/src/vsnprintf.h
+
 	#define snprintf(buf,len,args...)	sprintf(buf,args)
 	#define vsnprintf(buf,len,format,valist)	vsprintf(buf,format,valist)
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.