[Scummvm-cvs-logs] SF.net SVN: scummvm:[54027] scummvm/trunk/engines/tinsel/detection.cpp

[fingolfin at users.sourceforge.net]

Revision: 54027
          http://scummvm.svn.sourceforge.net/scummvm/?rev=54027&view=rev
Author:   fingolfin
Date:     2010-11-01 20:49:55 +0000 (Mon, 01 Nov 2010)

Log Message:
-----------
TINSEL: Explain why exactly RTL is disabled

The very same issue probably affects more engines, possibly even some
which have RTL enabled.

Modified Paths:
--------------
    scummvm/trunk/engines/tinsel/detection.cpp

Modified: scummvm/trunk/engines/tinsel/detection.cpp
===================================================================
--- scummvm/trunk/engines/tinsel/detection.cpp	2010-11-01 20:48:25 UTC (rev 54026)
+++ scummvm/trunk/engines/tinsel/detection.cpp	2010-11-01 20:49:55 UTC (rev 54027)
@@ -133,7 +133,14 @@
 bool Tinsel::TinselEngine::hasFeature(EngineFeature f) const {
 	return
 #if 0
-		// FIXME: tinsel does not exit cleanly yet
+		// FIXME: It is possible to return to the launcher from tinsel.
+		// But then any attempt to re-enter the engine will lead to
+		// a crash or at least seriously broken behavior.
+		//
+		// This is because the Tinsel engine makes use of tons of
+		// global variables (static and non-static) which are never
+		// explicitly re-initialized when the engine is started
+		// for a second time.
 		(f == kSupportsRTL) ||
 #endif
 		(f == kSupportsLoadingDuringRuntime);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.