[Scummvm-cvs-logs] SF.net SVN: scummvm:[54105] scummvm/trunk/engines

[fingolfin at users.sourceforge.net]

Revision: 54105
          http://scummvm.svn.sourceforge.net/scummvm/?rev=54105&view=rev
Author:   fingolfin
Date:     2010-11-07 01:01:18 +0000 (Sun, 07 Nov 2010)

Log Message:
-----------
ENGINES: Unify code layout of all ADParams instances

Modified Paths:
--------------
    scummvm/trunk/engines/draci/detection.cpp
    scummvm/trunk/engines/kyra/detection.cpp
    scummvm/trunk/engines/teenagent/detection.cpp
    scummvm/trunk/engines/testbed/detection.cpp
    scummvm/trunk/engines/toon/detection.cpp
    scummvm/trunk/engines/touche/detection.cpp
    scummvm/trunk/engines/tucker/detection.cpp

Modified: scummvm/trunk/engines/draci/detection.cpp
===================================================================
--- scummvm/trunk/engines/draci/detection.cpp	2010-11-07 00:37:04 UTC (rev 54104)
+++ scummvm/trunk/engines/draci/detection.cpp	2010-11-07 01:01:18 UTC (rev 54105)
@@ -86,7 +86,7 @@
 
 } // End of namespace Draci
 
-const ADParams detectionParams = {
+static const ADParams detectionParams = {
 	// Pointer to ADGameDescription or its superset structure
 	(const byte *)Draci::gameDescriptions,
 	// Size of that superset structure
@@ -103,7 +103,7 @@
 	0,
 	// Flags
 	0,
-	// Global GUI options
+	// Additional GUI options (for every game}
 	Common::GUIO_NONE,
 	// Maximum directory depth
 	1,

Modified: scummvm/trunk/engines/kyra/detection.cpp
===================================================================
--- scummvm/trunk/engines/kyra/detection.cpp	2010-11-07 00:37:04 UTC (rev 54104)
+++ scummvm/trunk/engines/kyra/detection.cpp	2010-11-07 01:01:18 UTC (rev 54105)
@@ -50,7 +50,7 @@
 	0
 };
 
-const ADParams detectionParams = {
+static const ADParams detectionParams = {
 	// Pointer to ADGameDescription or its superset structure
 	(const byte *)adGameDescs,
 	// Size of that superset structure

Modified: scummvm/trunk/engines/teenagent/detection.cpp
===================================================================
--- scummvm/trunk/engines/teenagent/detection.cpp	2010-11-07 00:37:04 UTC (rev 54104)
+++ scummvm/trunk/engines/teenagent/detection.cpp	2010-11-07 01:01:18 UTC (rev 54105)
@@ -83,16 +83,27 @@
 };
 
 static const ADParams detectionParams = {
+	// Pointer to ADGameDescription or its superset structure
 	(const byte *)teenAgentGameDescriptions,
+	// Size of that superset structure
 	sizeof(ADGameDescription),
+	// Number of bytes to compute MD5 sum for
 	5000,
+	// List of all engine targets
 	teenAgentGames,
+	// Structure for autoupgrading obsolete targets
 	0,
+	// Name of single gameid (optional)
 	"teenagent",
+	// List of files for file-based fallback detection (optional)
 	0,
+	// Flags
 	0,
+	// Additional GUI options (for every game}
 	Common::GUIO_NONE,
+	// Maximum directory depth
 	1,
+	// List of directory globs
 	0
 };
 

Modified: scummvm/trunk/engines/testbed/detection.cpp
===================================================================
--- scummvm/trunk/engines/testbed/detection.cpp	2010-11-07 00:37:04 UTC (rev 54104)
+++ scummvm/trunk/engines/testbed/detection.cpp	2010-11-07 01:01:18 UTC (rev 54105)
@@ -51,16 +51,27 @@
 };
 
 static const ADParams detectionParams = {
+	// Pointer to ADGameDescription or its superset structure
 	(const byte *)testbedDescriptions,
+	// Size of that superset structure
 	sizeof(ADGameDescription),
+	// Number of bytes to compute MD5 sum for
 	512,
+	// List of all engine targets
 	testbed_setting,
+	// Structure for autoupgrading obsolete targets
 	0,
+	// Name of single gameid (optional)
 	"testbed",
+	// List of files for file-based fallback detection (optional)
 	0,
+	// Flags
 	ADGF_NO_FLAGS,
+	// Additional GUI options (for every game}
 	Common::GUIO_NONE,
+	// Maximum directory depth
 	1,
+	// List of directory globs
 	0
 };
 

Modified: scummvm/trunk/engines/toon/detection.cpp
===================================================================
--- scummvm/trunk/engines/toon/detection.cpp	2010-11-07 00:37:04 UTC (rev 54104)
+++ scummvm/trunk/engines/toon/detection.cpp	2010-11-07 01:01:18 UTC (rev 54105)
@@ -112,13 +112,21 @@
 };
 
 static const ADParams detectionParams = {
+	// Pointer to ADGameDescription or its superset structure
 	(const byte *)Toon::gameDescriptions,
+	// Size of that superset structure
 	sizeof(ADGameDescription),
-	5000, // number of md5 bytes
+	// Number of bytes to compute MD5 sum for
+	5000,
+	// List of all engine targets
 	ToonGames,
-	0, // no obsolete targets data
+	// Structure for autoupgrading obsolete targets
+	0,
+	// Name of single gameid (optional)
 	"toon",
+	// List of files for file-based fallback detection (optional)
 	Toon::fileBasedFallback,
+	// Flags
 	0,
 	// Additional GUI options (for every game}
 	Common::GUIO_NONE,

Modified: scummvm/trunk/engines/touche/detection.cpp
===================================================================
--- scummvm/trunk/engines/touche/detection.cpp	2010-11-07 00:37:04 UTC (rev 54104)
+++ scummvm/trunk/engines/touche/detection.cpp	2010-11-07 01:01:18 UTC (rev 54105)
@@ -130,13 +130,21 @@
 };
 
 static const ADParams detectionParams = {
+	// Pointer to ADGameDescription or its superset structure
 	(const byte *)Touche::gameDescriptions,
+	// Size of that superset structure
 	sizeof(ADGameDescription),
-	4096, // number of md5 bytes
+	// Number of bytes to compute MD5 sum for
+	4096,
+	// List of all engine targets
 	toucheGames,
-	0, // no obsolete targets data
+	// Structure for autoupgrading obsolete targets
+	0,
+	// Name of single gameid (optional)
 	"touche",
-	Touche::fileBasedFallback, // file-based detection data to enable not yet known versions to start
+	// List of files for file-based fallback detection (optional)
+	Touche::fileBasedFallback,
+	// Flags
 	kADFlagPrintWarningOnFileBasedFallback,
 	// Additional GUI options (for every game}
 	Common::GUIO_NONE,

Modified: scummvm/trunk/engines/tucker/detection.cpp
===================================================================
--- scummvm/trunk/engines/tucker/detection.cpp	2010-11-07 00:37:04 UTC (rev 54104)
+++ scummvm/trunk/engines/tucker/detection.cpp	2010-11-07 01:01:18 UTC (rev 54105)
@@ -106,16 +106,27 @@
 };
 
 static const ADParams detectionParams = {
+	// Pointer to ADGameDescription or its superset structure
 	(const byte *)tuckerGameDescriptions,
+	// Size of that superset structure
 	sizeof(ADGameDescription),
+	// Number of bytes to compute MD5 sum for
 	512,
+	// List of all engine targets
 	tuckerGames,
+	// Structure for autoupgrading obsolete targets
 	0,
+	// Name of single gameid (optional)
 	"tucker",
+	// List of files for file-based fallback detection (optional)
 	0,
+	// Flags
 	0,
+	// Additional GUI options (for every game}
 	Common::GUIO_NONE,
+	// Maximum directory depth
 	1,
+	// List of directory globs
 	0
 };
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.