[Scummvm-cvs-logs] SF.net SVN: scummvm:[54299] scummvm/trunk/engines/cruise/cruise.cpp

tdhs at users.sourceforge.net tdhs at users.sourceforge.net
Wed Nov 17 20:29:07 CET 2010


Revision: 54299
          http://scummvm.svn.sourceforge.net/scummvm/?rev=54299&view=rev
Author:   tdhs
Date:     2010-11-17 19:29:07 +0000 (Wed, 17 Nov 2010)

Log Message:
-----------
CRUISE: Corrected uninit read of _polyStruct in ctp.cpp:49 detected by Valgrind.

This occurred during intro playback and was due to _polyStruct not being initialised to NULL during engine construction/initialisation.

Modified Paths:
--------------
    scummvm/trunk/engines/cruise/cruise.cpp

Modified: scummvm/trunk/engines/cruise/cruise.cpp
===================================================================
--- scummvm/trunk/engines/cruise/cruise.cpp	2010-11-17 18:46:29 UTC (rev 54298)
+++ scummvm/trunk/engines/cruise/cruise.cpp	2010-11-17 19:29:07 UTC (rev 54299)
@@ -101,7 +101,6 @@
 	Cruise::changeCursor(Cruise::CURSOR_NORMAL);
 	CursorMan.showMouse(true);
 
-
 	lastTick = 0;
 	lastTickDebug = 0;
 
@@ -130,6 +129,7 @@
 	// another bit of video init
 
 	readVolCnf();
+	_vm->_polyStruct = NULL;
 }
 
 void CruiseEngine::deinitialise() {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list