[Scummvm-cvs-logs] SF.net SVN: scummvm:[54366] scummvm/trunk/engines/lastexpress/data/ animation.cpp

[littleboy at users.sourceforge.net]

Revision: 54366
          http://scummvm.svn.sourceforge.net/scummvm/?rev=54366&view=rev
Author:   littleboy
Date:     2010-11-19 10:55:21 +0000 (Fri, 19 Nov 2010)

Log Message:
-----------
LASTEXPRESS: Simplify current frame calculation in Animation::process

(per Max suggestion)

Modified Paths:
--------------
    scummvm/trunk/engines/lastexpress/data/animation.cpp

Modified: scummvm/trunk/engines/lastexpress/data/animation.cpp
===================================================================
--- scummvm/trunk/engines/lastexpress/data/animation.cpp	2010-11-19 10:28:43 UTC (rev 54365)
+++ scummvm/trunk/engines/lastexpress/data/animation.cpp	2010-11-19 10:55:21 UTC (rev 54366)
@@ -106,8 +106,11 @@
 	if (_stream == NULL || _chunks.size() == 0)
 		error("Trying to show an animation before loading data");
 
-	// TODO: substract the time paused by the GUI
-	int32 currentFrame = Common::Rational((g_engine->_system->getMillis() - _startTime) * 100, 3333).toInt();
+	// TODO: - subtract the time paused by the GUI
+	//       - Re-implement to be closer to the original engine
+	//       - Add support for subtitles
+	//       - Use engine sound queue instead of our own appendable sound instance
+	int32 currentFrame = (g_engine->_system->getMillis() - _startTime) * 3 / 100;
 
 	// Process all chunks until the current frame
 	while (!_changed && _currentChunk != NULL && currentFrame > _currentChunk->frame && !hasEnded()) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.