[Scummvm-cvs-logs] SF.net SVN: scummvm:[54484] scummvm/trunk/engines/sci/sound/drivers/midi. cpp

thebluegr at users.sourceforge.net thebluegr at users.sourceforge.net
Thu Nov 25 23:23:15 CET 2010


Revision: 54484
          http://scummvm.svn.sourceforge.net/scummvm/?rev=54484&view=rev
Author:   thebluegr
Date:     2010-11-25 22:23:14 +0000 (Thu, 25 Nov 2010)

Log Message:
-----------
SCI: Some reverb-related changes in the MIDI driver, based on a patch by waltervn

Modified Paths:
--------------
    scummvm/trunk/engines/sci/sound/drivers/midi.cpp

Modified: scummvm/trunk/engines/sci/sound/drivers/midi.cpp
===================================================================
--- scummvm/trunk/engines/sci/sound/drivers/midi.cpp	2010-11-25 22:17:23 UTC (rev 54483)
+++ scummvm/trunk/engines/sci/sound/drivers/midi.cpp	2010-11-25 22:23:14 UTC (rev 54484)
@@ -385,10 +385,11 @@
 
 void MidiPlayer_Midi::setReverb(int8 reverb) {
 	assert(reverb < kReverbConfigNr);
+	
+	if (_hasReverb && (_reverb != reverb))
+		sendMt32SysEx(0x100001, _reverbConfig[reverb], 3, true);
+
 	_reverb = reverb;
-
-	if (_hasReverb)
-		sendMt32SysEx(0x100001, _reverbConfig[_reverb], 3, true);
 }
 
 void MidiPlayer_Midi::playSwitch(bool play) {
@@ -477,7 +478,10 @@
 	setMt32Volume(volume);
 
 	// Reverb default only used in (roughly) SCI0/SCI01
-	_reverb = str->readByte();
+	byte reverb = str->readByte();
+	if (_version <= SCI_VERSION_0_LATE)
+		setReverb(reverb);
+
 	_hasReverb = true;
 
 	// Skip reverb SysEx message


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list