[Scummvm-cvs-logs] SF.net SVN: scummvm:[54508] scummvm/trunk/sound/midiparser.cpp

[thebluegr at users.sourceforge.net]

Revision: 54508
          http://scummvm.svn.sourceforge.net/scummvm/?rev=54508&view=rev
Author:   thebluegr
Date:     2010-11-27 17:23:24 +0000 (Sat, 27 Nov 2010)

Log Message:
-----------
MidiParser: updated comment concerning note on events in jumpToTick()

Modified Paths:
--------------
    scummvm/trunk/sound/midiparser.cpp

Modified: scummvm/trunk/sound/midiparser.cpp
===================================================================
--- scummvm/trunk/sound/midiparser.cpp	2010-11-27 16:48:38 UTC (rev 54507)
+++ scummvm/trunk/sound/midiparser.cpp	2010-11-27 17:23:24 UTC (rev 54508)
@@ -403,12 +403,12 @@
 					else
 						_driver->sysEx(info.ext.data, (uint16)info.length);
 				} else {
+					// The note on sending code is used by the SCUMM engine. Other engine using this code
+					// (such as SCI) have issues with this, as all the notes sent can be heard when a song
+					// is fast-forwarded.	Thus, if the engine requests it, don't send note on events.
 					if (info.command() == 0x9 && dontSendNoteOn) {
 						// Don't send note on; doing so creates a "warble" with some instruments on the MT-32.
 						// Refer to patch #3117577
-
-						// TODO: this is currently done by SCI only, but it seems sensible enough to do this
-						// for all engines
 					} else {
 						sendToDriver(info.event, info.basic.param1, info.basic.param2);
 					}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.