[Scummvm-cvs-logs] SF.net SVN: scummvm:[52986] scummvm/trunk/engines/sci/parser/grammar.cpp

[wjpalenstijn at users.sourceforge.net]

Revision: 52986
          http://scummvm.svn.sourceforge.net/scummvm/?rev=52986&view=rev
Author:   wjpalenstijn
Date:     2010-10-02 23:17:19 +0000 (Sat, 02 Oct 2010)

Log Message:
-----------
SCI: Fix memleak

Modified Paths:
--------------
    scummvm/trunk/engines/sci/parser/grammar.cpp

Modified: scummvm/trunk/engines/sci/parser/grammar.cpp
===================================================================
--- scummvm/trunk/engines/sci/parser/grammar.cpp	2010-10-02 23:17:03 UTC (rev 52985)
+++ scummvm/trunk/engines/sci/parser/grammar.cpp	2010-10-02 23:17:19 UTC (rev 52986)
@@ -277,10 +277,8 @@
 		while (seeker->next/* && seeker->next->terminal <= term*/) {
 			if (seeker->next->terminal == term) {
 				if (*(seeker->next->rule) == *rule) {
-					delete rule;
-					// FIXME: not sure about this change, fixes pq2 crashing when having opened the cabinet
-					//  and typing "go to bains" - delete rule deletes part of new_elem
-					//delete new_elem;
+					delete new_elem; // NB: This also deletes 'rule'
+
 					return list; // No duplicate rules
 				}
 			}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.