[Scummvm-cvs-logs] SF.net SVN: scummvm:[52497] scummvm/trunk/engines/sci/engine/kparse.cpp

thebluegr at users.sourceforge.net thebluegr at users.sourceforge.net
Thu Sep 2 15:50:50 CEST 2010


Revision: 52497
          http://scummvm.svn.sourceforge.net/scummvm/?rev=52497&view=rev
Author:   thebluegr
Date:     2010-09-02 13:50:49 +0000 (Thu, 02 Sep 2010)

Log Message:
-----------
SCI: Added a FIXME for bug #3038870, related to kParse()

Modified Paths:
--------------
    scummvm/trunk/engines/sci/engine/kparse.cpp

Modified: scummvm/trunk/engines/sci/engine/kparse.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/kparse.cpp	2010-09-02 12:52:03 UTC (rev 52496)
+++ scummvm/trunk/engines/sci/engine/kparse.cpp	2010-09-02 13:50:49 UTC (rev 52497)
@@ -138,6 +138,15 @@
 	} else {
 
 		s->r_acc = make_reg(0, 0);
+		// FIXME: When typing something wrong in the fanmade game Demo Quest,
+		// after the error dialog, the game checks for claimed to be 0 before
+		// showing a subsequent dialog. The following selector change causes
+		// it to be 1, thus causing the game to hang in an endless loop (bug
+		// #3038870. Thus, this seems to be wrong (since fanmade games use
+		// the original SCI interpreter), but we need to check against
+		// dissassembly. Since kParse is in the process of being dissassembled
+		// again, I'm leaving this FIXME in for now, so that it won't be
+		// forgotten :)
 		writeSelectorValue(segMan, event, SELECTOR(claimed), 1);
 		if (error) {
 			s->_segMan->strcpy(voc->parser_base, error);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list