[Scummvm-cvs-logs] SF.net SVN: scummvm:[52505] scummvm/trunk/engines/sci/sound/drivers/midi. cpp

thebluegr at users.sourceforge.net thebluegr at users.sourceforge.net
Fri Sep 3 14:42:35 CEST 2010


Revision: 52505
          http://scummvm.svn.sourceforge.net/scummvm/?rev=52505&view=rev
Author:   thebluegr
Date:     2010-09-03 12:42:35 +0000 (Fri, 03 Sep 2010)

Log Message:
-----------
SCI: Added a warning when using GM with SCI1 games

The MT-32 <-> GM mapping has only been worked on for
SCI0/SCI01 games. Throw a warning when the user
chooses GM in a SCI1 game, and there is no after
market GM support from Sierra for this game

Modified Paths:
--------------
    scummvm/trunk/engines/sci/sound/drivers/midi.cpp

Modified: scummvm/trunk/engines/sci/sound/drivers/midi.cpp
===================================================================
--- scummvm/trunk/engines/sci/sound/drivers/midi.cpp	2010-09-03 08:46:07 UTC (rev 52504)
+++ scummvm/trunk/engines/sci/sound/drivers/midi.cpp	2010-09-03 12:42:35 UTC (rev 52505)
@@ -834,6 +834,14 @@
 
 			warning("Game has no native support for General MIDI, applying auto-mapping");
 
+			// TODO: The MT-32 <-> GM mapping hasn't been worked on for SCI1 games. Throw
+			// a warning to the user
+			if (getSciVersion() >= SCI_VERSION_1_EGA)
+				warning("The automatic mapping for General MIDI hasn't been worked on for "
+						"SCI1 games. Music might sound wrong or broken. Please choose another "
+						"music driver for this game (e.g. Adlib or MT-32) if you are "
+						"experiencing issues with music");
+
 			// Modify velocity map to make low velocity notes a little louder
 			for (uint i = 1; i < 0x40; i++) {
 				_velocityMap[0][i] = 0x20 + (i - 1) / 2;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list