[Scummvm-cvs-logs] SF.net SVN: scummvm:[52586] scummvm/trunk/engines/sci/engine/ static_selectors.cpp

thebluegr at users.sourceforge.net thebluegr at users.sourceforge.net
Mon Sep 6 13:30:27 CEST 2010


Revision: 52586
          http://scummvm.svn.sourceforge.net/scummvm/?rev=52586&view=rev
Author:   thebluegr
Date:     2010-09-06 11:30:26 +0000 (Mon, 06 Sep 2010)

Log Message:
-----------
SCI: Fixed an off-by one access error in the static selectors of some games

Modified Paths:
--------------
    scummvm/trunk/engines/sci/engine/static_selectors.cpp

Modified: scummvm/trunk/engines/sci/engine/static_selectors.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/static_selectors.cpp	2010-09-06 10:41:14 UTC (rev 52585)
+++ scummvm/trunk/engines/sci/engine/static_selectors.cpp	2010-09-06 11:30:26 UTC (rev 52586)
@@ -184,8 +184,8 @@
 				// The init selector is always the first function
 				int initSelectorPos = actorClass->getFuncSelector(0);
 
-				if (names.size() < (uint32)initSelectorPos + 1)
-					names.resize((uint32)initSelectorPos + 1);
+				if (names.size() < (uint32)initSelectorPos + 2)
+					names.resize((uint32)initSelectorPos + 2);
 
 				names[initSelectorPos] = "init";
 				// dispose comes right after init


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list