[Scummvm-cvs-logs] scummvm master -> 41706cb4d9c2fe383de11bf84b73e46b9f9147f9

lordhoto lordhoto at gmail.com
Wed Apr 13 23:32:12 CEST 2011


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
41706cb4d9 TSAGE: Silence uninitialized variable usage warning.


Commit: 41706cb4d9c2fe383de11bf84b73e46b9f9147f9
    https://github.com/scummvm/scummvm/commit/41706cb4d9c2fe383de11bf84b73e46b9f9147f9
Author: Johannes Schickel (lordhoto at scummvm.org)
Date: 2011-04-13T14:33:22-07:00

Commit Message:
TSAGE: Silence uninitialized variable usage warning.

Instead of passing an uninitialized dummy va_list to Action::attached we just
pass the va parameter from SequenceManager::attached to it now, since that
parameter is not used in Action::attached, it is safe to do that.

Changed paths:
    engines/tsage/converse.cpp



diff --git a/engines/tsage/converse.cpp b/engines/tsage/converse.cpp
index 8398987..bcda6db 100644
--- a/engines/tsage/converse.cpp
+++ b/engines/tsage/converse.cpp
@@ -320,12 +320,7 @@ void SequenceManager::attached(EventHandler *newOwner, EventHandler *fmt, va_lis
 	}
 
 	setup();
-	// TODO: This is not particulary nice, since dummy is uninitialized.
-	// Since the default Action implementation does not access the va_list
-	// parameter it should be fine though. Still it would be nice to find
-	// a better solution to this.
-	va_list dummy;
-	Action::attached(newOwner, fmt, dummy);
+	Action::attached(newOwner, fmt, va);
 }
 
 /**






More information about the Scummvm-git-logs mailing list