[Scummvm-cvs-logs] scummvm master -> bcd07d35bb0c5307dfb0864afa3586deba96132c

lordhoto lordhoto at gmail.com
Sat Aug 6 18:58:49 CEST 2011


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
bcd07d35bb OSYSTEM: Mention that our OSystem graphics API is not thread safe.


Commit: bcd07d35bb0c5307dfb0864afa3586deba96132c
    https://github.com/scummvm/scummvm/commit/bcd07d35bb0c5307dfb0864afa3586deba96132c
Author: Johannes Schickel (lordhoto at gmail.com)
Date: 2011-08-06T09:55:32-07:00

Commit Message:
OSYSTEM: Mention that our OSystem graphics API is not thread safe.

Based on f621f6a5059ec619ae9ea1045548e62a27e99ab4 and the fact that our OpenGL
based backends do not (and sometimes cannot easily) implement it in a thread
safe manner.

Changed paths:
    common/system.h



diff --git a/common/system.h b/common/system.h
index 600778d..413fe32 100644
--- a/common/system.h
+++ b/common/system.h
@@ -403,6 +403,11 @@ public:
 	 * factor 2x, too, just like the game graphics. But if it has a
 	 * cursorTargetScale of 2, then it shouldn't be scaled again by
 	 * the game graphics scaler.
+	 *
+	 * On a note for OSystem users here. We do not require our graphics
+	 * to be thread safe and in fact most/all backends using OpenGL are
+	 * not. So do *not* try to call any of these functions from a timer
+	 * and/or audio callback (like readBuffer of AudioStreams).
 	 */
 	//@{
 






More information about the Scummvm-git-logs mailing list