[Scummvm-cvs-logs] scummvm master -> 00d25a77a9d8297fdc356c7a10f9dc2d94903a5f

lordhoto lordhoto at gmail.com
Tue Aug 9 15:08:01 CEST 2011


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
00d25a77a9 RECORDER: Defer mutex deletion to destructor.


Commit: 00d25a77a9d8297fdc356c7a10f9dc2d94903a5f
    https://github.com/scummvm/scummvm/commit/00d25a77a9d8297fdc356c7a10f9dc2d94903a5f
Author: Johannes Schickel (lordhoto at scummvm.org)
Date: 2011-08-09T06:04:26-07:00

Commit Message:
RECORDER: Defer mutex deletion to destructor.

Since we now call deinit after a game has been run, otherwise RTL would be
broken. See bug report #3388982 "valgrind errors when doing multiple RTL".

Changed paths:
    common/EventRecorder.cpp



diff --git a/common/EventRecorder.cpp b/common/EventRecorder.cpp
index 7383248..3be3161 100644
--- a/common/EventRecorder.cpp
+++ b/common/EventRecorder.cpp
@@ -133,6 +133,9 @@ EventRecorder::EventRecorder() {
 
 EventRecorder::~EventRecorder() {
 	deinit();
+
+	g_system->deleteMutex(_timeMutex);
+	g_system->deleteMutex(_recorderMutex);
 }
 
 void EventRecorder::init() {
@@ -282,9 +285,6 @@ void EventRecorder::deinit() {
 
 		//TODO: remove recordTempFileName'ed file
 	}
-
-	g_system->deleteMutex(_timeMutex);
-	g_system->deleteMutex(_recorderMutex);
 }
 
 void EventRecorder::registerRandomSource(RandomSource &rnd, const String &name) {






More information about the Scummvm-git-logs mailing list