[Scummvm-cvs-logs] scummvm master -> 4b6c1a0c2b53fdb71090759fbd89a6852d84af4b

digitall digitall at scummvm.org
Thu Jun 2 04:29:46 CEST 2011


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
4b6c1a0c2b DRACI: Replace snprintf() usage with Common::String::format()


Commit: 4b6c1a0c2b53fdb71090759fbd89a6852d84af4b
    https://github.com/scummvm/scummvm/commit/4b6c1a0c2b53fdb71090759fbd89a6852d84af4b
Author: D G Turner (digitall at scummvm.org)
Date: 2011-06-01T19:27:44-07:00

Commit Message:
DRACI: Replace snprintf() usage with Common::String::format()

Safer and less portability issues.

Changed paths:
    engines/draci/music.cpp



diff --git a/engines/draci/music.cpp b/engines/draci/music.cpp
index 6f3e3c8..3179c79 100644
--- a/engines/draci/music.cpp
+++ b/engines/draci/music.cpp
@@ -80,9 +80,8 @@ void MusicPlayer::playSMF(int track, bool loop) {
 
 	// Load MIDI resource data
 	Common::File musicFile;
-	char musicFileName[40];
-	snprintf(musicFileName, sizeof(musicFileName), _pathMask.c_str(), track);
-	musicFile.open(musicFileName);
+	Common::String musicFileName = Common::String::format(_pathMask.c_str(), track);
+	musicFile.open(musicFileName.c_str());
 	if (!musicFile.isOpen()) {
 		debugC(2, kDraciSoundDebugLevel, "Cannot open track %d", track);
 		return;






More information about the Scummvm-git-logs mailing list