[Scummvm-cvs-logs] scummvm master -> 6a6b9aabeaca1737000401c6099fd39b00eb351e

[fingolfin]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
6a6b9aabea TSAGE: Elaborate on one FIXME I previously added, resolve another


Commit: 6a6b9aabeaca1737000401c6099fd39b00eb351e
    https://github.com/scummvm/scummvm/commit/6a6b9aabeaca1737000401c6099fd39b00eb351e
Author: Max Horn (max at quendi.de)
Date: 2011-06-10T13:39:23-07:00

Commit Message:
TSAGE: Elaborate on one FIXME I previously added, resolve another

Turns out params.depth == 0 is the same as == 1

Changed paths:
    engines/tsage/detection.cpp



diff --git a/engines/tsage/detection.cpp b/engines/tsage/detection.cpp
index 57ba997..8aae6aa 100644
--- a/engines/tsage/detection.cpp
+++ b/engines/tsage/detection.cpp
@@ -73,10 +73,19 @@ enum {
 class TSageMetaEngine : public AdvancedMetaEngine {
 public:
 	TSageMetaEngine() : AdvancedMetaEngine(tSage::gameDescriptions, sizeof(tSage::tSageGameDescription), tSageGameTitles) {
-		params.md5Bytes = 0;	// FIXME ????
+		// FIXME: Using 0 for md5Bytes means that the whole file will checked.
+		// this is usually a bad idea, as it can cause terribly slowdowns
+		// (remember, the MD5 is recomputed whenever the game starts, and also
+		// for many, many files when doing a "Mass Add" from the launcher. Even
+		// if the files you currently use for detection are all just a few
+		// kilobytes, you should still set a value here, just in case in the
+		// future you'll end up detecting with somewhat bigger files.
+		// I recommend using the default of 5000 here; if this is not possible,
+		// try a value like 10000 or 1024*1024, but be prepared to here from
+		// some suffering users ;)
+		params.md5Bytes = 0;
 		params.singleid = "tsage";
 		params.guioptions = Common::GUIO_NOSPEECH;
-		params.depth = 0;	// FIXME ????
 	}
 
 	virtual const char *getName() const {