[Scummvm-cvs-logs] scummvm master -> f9f16ee35823db90ff561b06af05a2c02d341fc9

[lordhoto]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
e0eb86826e OPENGL: Clarify OSD rect color in a comment.
f9f16ee358 OPENGLSDL: Add FIXME about desktop resolution retrieving.


Commit: e0eb86826e5855bae1a8cc2ce81fa935b891d128
    https://github.com/scummvm/scummvm/commit/e0eb86826e5855bae1a8cc2ce81fa935b891d128
Author: Johannes Schickel (lordhoto at scummvm.org)
Date: 2011-06-19T10:03:10-07:00

Commit Message:
OPENGL: Clarify OSD rect color in a comment.

Changed paths:
    backends/graphics/opengl/opengl-graphics.cpp



diff --git a/backends/graphics/opengl/opengl-graphics.cpp b/backends/graphics/opengl/opengl-graphics.cpp
index 9ec38db..4c2c70d 100644
--- a/backends/graphics/opengl/opengl-graphics.cpp
+++ b/backends/graphics/opengl/opengl-graphics.cpp
@@ -1413,7 +1413,7 @@ void OpenGLGraphicsManager::updateOSD() {
 	int dstX = (_osdSurface.w - width) / 2;
 	int dstY = (_osdSurface.h - height) / 2;
 
-	// Draw a dark gray rect
+	// Draw a dark gray rect (R = 40, G = 40, B = 40)
 	const uint16 color = 0x294B;
 	_osdSurface.fillRect(Common::Rect(dstX, dstY, dstX + width, dstY + height), color);
 


Commit: f9f16ee35823db90ff561b06af05a2c02d341fc9
    https://github.com/scummvm/scummvm/commit/f9f16ee35823db90ff561b06af05a2c02d341fc9
Author: Johannes Schickel (lordhoto at scummvm.org)
Date: 2011-06-19T10:12:34-07:00

Commit Message:
OPENGLSDL: Add FIXME about desktop resolution retrieving.

Changed paths:
    backends/graphics/openglsdl/openglsdl-graphics.cpp



diff --git a/backends/graphics/openglsdl/openglsdl-graphics.cpp b/backends/graphics/openglsdl/openglsdl-graphics.cpp
index 0fcee18..eefba59 100644
--- a/backends/graphics/openglsdl/openglsdl-graphics.cpp
+++ b/backends/graphics/openglsdl/openglsdl-graphics.cpp
@@ -54,6 +54,10 @@ OpenGLSdlGraphicsManager::OpenGLSdlGraphicsManager()
 	SDL_ShowCursor(SDL_DISABLE);
 
 	// Get desktop resolution
+	// TODO: In case the OpenGL manager is created *after* a plain SDL manager
+	// has been used, this will return the last setup graphics mode rather
+	// than the desktop resolution. We should really look into a way to
+	// properly retrieve the desktop resolution.
 	const SDL_VideoInfo *videoInfo = SDL_GetVideoInfo();
 	if (videoInfo->current_w > 0 && videoInfo->current_h > 0) {
 		_desktopWidth = videoInfo->current_w;