[Scummvm-cvs-logs] scummvm master -> c222afc933aaf9f04d15c4bcc4dd4f6c38bae17a

Strangerke Strangerke at scummvm.org
Thu Feb 2 00:32:01 CET 2012


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
c222afc933 TSAGE: R2R - Avoid a crash in scene 700


Commit: c222afc933aaf9f04d15c4bcc4dd4f6c38bae17a
    https://github.com/scummvm/scummvm/commit/c222afc933aaf9f04d15c4bcc4dd4f6c38bae17a
Author: Strangerke (strangerke at scummvm.org)
Date: 2012-02-01T15:31:25-08:00

Commit Message:
TSAGE: R2R - Avoid a crash in scene 700

Changed paths:
    engines/tsage/ringworld2/ringworld2_scenes0.cpp



diff --git a/engines/tsage/ringworld2/ringworld2_scenes0.cpp b/engines/tsage/ringworld2/ringworld2_scenes0.cpp
index a4c2fe5..39bc41e 100644
--- a/engines/tsage/ringworld2/ringworld2_scenes0.cpp
+++ b/engines/tsage/ringworld2/ringworld2_scenes0.cpp
@@ -5614,7 +5614,11 @@ void Scene700::postInit(SceneObjectList *OwnerList) {
 
 void Scene700::remove() {
 	R2_GLOBALS._sound1.play(10);
-	_rotation->remove();
+// CHECKME: Present in the original... But it crashes badly.
+// The instruction was removed as it's not used in other scene coded the same way
+// and reversed by dreammaster. A double check is required in order to verify it doesn't hide 
+// a memory leak
+//	_rotation->remove();
 	SceneExt::remove();
 }
 






More information about the Scummvm-git-logs mailing list