[Scummvm-cvs-logs] scummvm master -> 8248944f1eb313f101e966a04aa93cb7db82559e

[bluegr]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
f4bf93fd67 ENGINES: Properly explain the usage of _singleId
8248944f1e SCI: Do not set _singleId in SciMetaEngine


Commit: f4bf93fd6765ff825ac502b64c5937a1cb90ea72
    https://github.com/scummvm/scummvm/commit/f4bf93fd6765ff825ac502b64c5937a1cb90ea72
Author: Filippos Karapetis (md5 at scummvm.org)
Date: 2012-02-28T00:38:42-08:00

Commit Message:
ENGINES: Properly explain the usage of _singleId

Changed paths:
    engines/advancedDetector.h



diff --git a/engines/advancedDetector.h b/engines/advancedDetector.h
index 3bb0061..2c7d9cc 100644
--- a/engines/advancedDetector.h
+++ b/engines/advancedDetector.h
@@ -171,7 +171,8 @@ protected:
 	/**
 	 * Name of single gameid (optional).
 	 *
-	 * @todo Properly explain this -- what does it do?
+	 * If set, the target ID will always be set to this one. Probably useful
+	 * for engines with few game targets.
 	 */
 	const char *_singleid;
 


Commit: 8248944f1eb313f101e966a04aa93cb7db82559e
    https://github.com/scummvm/scummvm/commit/8248944f1eb313f101e966a04aa93cb7db82559e
Author: Filippos Karapetis (md5 at scummvm.org)
Date: 2012-02-28T00:38:44-08:00

Commit Message:
SCI: Do not set _singleId in SciMetaEngine

This allows the engine to set the correct game ID to each entry. With
_singleId set, all the IDs in the game entries are set to "sci"

Changed paths:
    engines/sci/detection.cpp



diff --git a/engines/sci/detection.cpp b/engines/sci/detection.cpp
index c438490..bef357f 100644
--- a/engines/sci/detection.cpp
+++ b/engines/sci/detection.cpp
@@ -381,7 +381,6 @@ static char s_fallbackGameIdBuf[256];
 class SciMetaEngine : public AdvancedMetaEngine {
 public:
 	SciMetaEngine() : AdvancedMetaEngine(Sci::SciGameDescriptions, sizeof(ADGameDescription), s_sciGameTitles) {
-		_singleid = "sci";
 	}
 
 	virtual const char *getName() const {