[Scummvm-cvs-logs] scummvm master -> 3ce34294ee64cecd8ed9c282d59dcbaffb3ecfeb

wjp wjp at usecode.org
Wed Feb 29 13:14:07 CET 2012


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3ce34294ee ENGINES: Copy singleid description from wiki


Commit: 3ce34294ee64cecd8ed9c282d59dcbaffb3ecfeb
    https://github.com/scummvm/scummvm/commit/3ce34294ee64cecd8ed9c282d59dcbaffb3ecfeb
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2012-02-29T04:13:28-08:00

Commit Message:
ENGINES: Copy singleid description from wiki

Changed paths:
    engines/advancedDetector.h



diff --git a/engines/advancedDetector.h b/engines/advancedDetector.h
index 4f21539..0cec039 100644
--- a/engines/advancedDetector.h
+++ b/engines/advancedDetector.h
@@ -171,16 +171,13 @@ protected:
 	/**
 	 * Name of single gameid (optional).
 	 *
-	 * If set, the target ID will always be set to this one. This is necessary
-	 * for engines that define a lot of game targets, so that the global
-	 * namespace won't be polluted with loads of IDs, which could lead to a
-	 * situation where two different engines define the same game ID.
+	 * Used to override gameid.
+	 * This is a recommended setting to prevent global gameid pollution.
+	 * With this option set, the gameid effectively turns into engineid. 
 	 *
-	 * FIXME: This field actually removes a feature (game IDs) in order to
-	 * address a more generic problem. Another way to address this issue without
-	 * disabling game IDs altogether would be to distinguish targets with an
-	 * engineId-gameId combination, so that there will never be a duplicate
-	 * game ID across different engines.
+	 * FIXME: This field actually removes a feature (gameid) in order to
+	 * address a more generic problem. We should find a better way to
+	 * disambiguate gameids.
 	 */
 	const char *_singleid;
 






More information about the Scummvm-git-logs mailing list