[Scummvm-cvs-logs] scummvm master -> a0ad504059470b9ac8f5d4025d7bcec1621e1933

bluegr md5 at scummvm.org
Wed Jul 4 00:07:57 CEST 2012


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
a0ad504059 SCI: Update some kernel table related comments


Commit: a0ad504059470b9ac8f5d4025d7bcec1621e1933
    https://github.com/scummvm/scummvm/commit/a0ad504059470b9ac8f5d4025d7bcec1621e1933
Author: Filippos Karapetis (md5 at scummvm.org)
Date: 2012-07-03T15:06:58-07:00

Commit Message:
SCI: Update some kernel table related comments

Changed paths:
    engines/sci/engine/kernel.cpp
    engines/sci/engine/kernel_tables.h



diff --git a/engines/sci/engine/kernel.cpp b/engines/sci/engine/kernel.cpp
index 924641c..46051ef 100644
--- a/engines/sci/engine/kernel.cpp
+++ b/engines/sci/engine/kernel.cpp
@@ -837,7 +837,7 @@ void Kernel::loadKernelNames(GameFeatures *features) {
 
 	case SCI_VERSION_2_1:
 		if (features->detectSci21KernelType() == SCI_VERSION_2) {
-			// Some late SCI2.1 games use a modified SCI2 kernel table instead of
+			// Some early SCI2.1 games use a modified SCI2 kernel table instead of
 			// the SCI2.1 kernel table. We detect which version to use based on
 			// how kDoSound is called from Sound::play().
 			// Known games that use this:
diff --git a/engines/sci/engine/kernel_tables.h b/engines/sci/engine/kernel_tables.h
index 126e972..114cd58 100644
--- a/engines/sci/engine/kernel_tables.h
+++ b/engines/sci/engine/kernel_tables.h
@@ -828,7 +828,7 @@ static const char *const sci2_default_knames[] = {
 	/*0x20*/ "AddMagnify",
 	/*0x21*/ "DeleteMagnify",
 	/*0x22*/ "IsHiRes",
-	/*0x23*/ "Graph",
+	/*0x23*/ "Graph",		// Robot in early SCI2.1 games with a SCI2 kernel table
 	/*0x24*/ "InvertRect",	// only in SCI2, not used in any SCI2 game
 	/*0x25*/ "TextSize",
 	/*0x26*/ "Message",
@@ -839,7 +839,7 @@ static const char *const sci2_default_knames[] = {
 	/*0x2b*/ "EditText",
 	/*0x2c*/ "InputText",			// unused function
 	/*0x2d*/ "CreateTextBitmap",
-	/*0x2e*/ "DisposeTextBitmap",
+	/*0x2e*/ "DisposeTextBitmap",	// Priority in early SCI2.1 games with a SCI2 kernel table
 	/*0x2f*/ "GetEvent",
 	/*0x30*/ "GlobalToLocal",
 	/*0x31*/ "LocalToGlobal",






More information about the Scummvm-git-logs mailing list