[Scummvm-cvs-logs] scummvm master -> 398987ad7f83ffc44032658b94db5763fe83d344

lordhoto lordhoto at gmail.com
Mon Mar 5 20:23:52 CET 2012


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
398987ad7f KYRA: Replace debug leftover for unimplemented displayText functions with a warning.


Commit: 398987ad7f83ffc44032658b94db5763fe83d344
    https://github.com/scummvm/scummvm/commit/398987ad7f83ffc44032658b94db5763fe83d344
Author: Johannes Schickel (lordhoto at scummvm.org)
Date: 2012-03-05T11:23:01-08:00

Commit Message:
KYRA: Replace debug leftover for unimplemented displayText functions with a warning.

Changed paths:
    engines/kyra/text_rpg.cpp



diff --git a/engines/kyra/text_rpg.cpp b/engines/kyra/text_rpg.cpp
index b004270..52c14c7 100644
--- a/engines/kyra/text_rpg.cpp
+++ b/engines/kyra/text_rpg.cpp
@@ -188,11 +188,6 @@ void TextDisplayer_rpg::displayText(char *str, ...) {
 			_textDimData[sdx].column = (_screen->getFontWidth() + _screen->_charWidth) * dv;
 			break;
 
-		case 11:
-			_sjisLineBreakFlag = _sjisLineBreakFlag;
-			// TODO (UNUSED)
-			break;
-
 		case 12:
 			if (isPc98)
 				_sjisLineBreakFlag = true;
@@ -203,29 +198,12 @@ void TextDisplayer_rpg::displayText(char *str, ...) {
 			_textDimData[sdx].line++;
 			break;
 
-		case 18:
-			_sjisLineBreakFlag = _sjisLineBreakFlag;
-			// TODO (UNUSED)
-			break;
-
-		case 23:
-			_sjisLineBreakFlag = _sjisLineBreakFlag;
-			// TODO (UNUSED)
-			break;
-
-		case 24:
-			_sjisLineBreakFlag = _sjisLineBreakFlag;
-			// TODO (UNUSED)
-			break;
-
-		case 26:
-			_sjisLineBreakFlag = _sjisLineBreakFlag;
-			// TODO (UNUSED)
-			break;
-
-		case 28:
-			_sjisLineBreakFlag = _sjisLineBreakFlag;
-			// TODO (UNUSED)
+		case 11: case 18: case 23:
+		case 24: case 26: case 28:
+			// These are at the time of writing this comment not known to be
+			// used. In case there is some use of them in some odd version
+			// we display this warning here.
+			warning("TextDisplayer_rpg::displayText: Triggered stub function %d", c - 1);
 			break;
 
 		default:






More information about the Scummvm-git-logs mailing list